London | 26-ITP-May | Eyob Zeray | Sprint 3 | quote-generator - #1324
Open
eyob-tech wants to merge 1 commit into
Open
London | 26-ITP-May | Eyob Zeray | Sprint 3 | quote-generator#1324eyob-tech wants to merge 1 commit into
eyob-tech wants to merge 1 commit into
Conversation
cjyuan
reviewed
Aug 1, 2026
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Code looks good.
Note: We should respect instructions like DO NOT EDIT BELOW HERE; it is usually there for a reason. If you are curious about why, you could ask AI
Why should programmers respect "DO NOT EDIT BELOW HERE" instruction in a file?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Updated the <title> in index.html to "Quote generator app". Implemented
the quote generator logic in quotes.js: on page load, a random quote and
its author are displayed by picking from the provided quotes array using
pickFromArray(). Clicking the "New quote" button selects and displays a
new random quote and author each time. Both tests in quotes.test.js pass.