London | 26-ITP-May | Dagim Daniel | Sprint 1 | Exercises - #1337
Open
Dagim-Daniel wants to merge 1 commit into
Open
London | 26-ITP-May | Dagim Daniel | Sprint 1 | Exercises#1337Dagim-Daniel wants to merge 1 commit into
Dagim-Daniel wants to merge 1 commit into
Conversation
LonMcGregor
reviewed
Aug 1, 2026
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start. Most of these are working well, but it could be improved further
| @@ -1 +1,6 @@ | |||
| function dedupe() {} | |||
| function dedupe(value) { | |||
| const newDedupe = [...new Set(value)]; | |||
There was a problem hiding this comment.
Good use of sets, could the return code be simplified even further?
| const median = list.splice(middleIndex, 1)[0]; | ||
| // Filter out non-numeric values | ||
| // const numbers = list.filter((x) => typeof x === "number"); | ||
| const numbers = []; |
There was a problem hiding this comment.
Did you run the test case for this? I get an error when I try it
| const right = numbers[middleIndex]; | ||
| return (left + right) / 2; | ||
| } | ||
| //console.log(`middleIndex: ${middleIndex}`); |
There was a problem hiding this comment.
What benefit does this code give by being commented out?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…an suggests
Learners, PR Template
Self checklist
Changelist
All tasks under Sprint -1 is completed and i put all together as suggested