London | 26-ITP-May | Chinwe Chukwuma | Sprint 1 | Module-data-groups

Sprint-1/fix/median.js

@@ -6,9 +6,31 @@
 // or 'list' has mixed values (the function is expected to sort only numbers).
 
 function calculateMedian(list) {
-  const middleIndex = Math.floor(list.length / 2);
-  const median = list.splice(middleIndex, 1)[0];
-  return median;
+  // Validate input: must be an array
+  if (!Array.isArray(list)) {
+    return null;
+  }
+
+  // Filter out non-numeric values
+  const numbers = list.filter((item) => typeof item === "number");
+
+  // If no numeric values, return null
+  if (numbers.length === 0) {
+    return null;
+  }
+
+  // Sort numbers without mutating original list
+  const sorted = [...numbers].sort((a, b) => a - b);
+
+  const middleIndex = Math.floor(sorted.length / 2);
+
+  // Odd length → return middle number
+  if (sorted.length % 2 !== 0) {
+    return sorted[middleIndex];
+  }
+
+  // Even length → average of two middle numbers
+  return (sorted[middleIndex - 1] + sorted[middleIndex]) / 2;
 }
 
 module.exports = calculateMedian;

Sprint-1/implement/dedupe.js

@@ -1 +1,5 @@
-function dedupe() {}
+function dedupe(arr) {
+  return [...new Set(arr)];
+}
+
+module.exports = dedupe;

Sprint-1/implement/max.js

@@ -1,4 +1,9 @@
 function findMax(elements) {
+  const numbers = elements.filter((item) => typeof item === "number");
+  if (numbers.length === 0) {
+    return -Infinity;
+  }
+  return Math.max(...numbers);
 }
 
 module.exports = findMax;

Sprint-1/implement/max.test.js

@@ -16,28 +16,49 @@ const findMax = require("./max.js");
 // When passed to the max function
 // Then it should return -Infinity
 // Delete this test.todo and replace it with a test.
-test.todo("given an empty array, returns -Infinity");
+//test.todo("given an empty array, returns -Infinity");
+test("given an empty array, returns -Infinity", () => {
+  expect(findMax([])).toBe(-Infinity);
+});
 
 // Given an array with one number
 // When passed to the max function
 // Then it should return that number
+test("given an array with one number, returns that number", () => {
+  expect(findMax([42])).toBe(42);
+});
 
 // Given an array with both positive and negative numbers
 // When passed to the max function
 // Then it should return the largest number overall
+test("given an array with positive and negative numbers, returns the largest", () => {
+  expect(findMax([-10, 5, 3, -2])).toBe(5);
+});
 
 // Given an array with just negative numbers
 // When passed to the max function
 // Then it should return the closest one to zero
+test("given an array with only negative numbers, returns the closest to zero", () => {
+  expect(findMax([-10, -3, -20])).toBe(-3);
+});
 
 // Given an array with decimal numbers
 // When passed to the max function
 // Then it should return the largest decimal number
+test("given an array with decimal numbers, returns the largest decimal", () => {
+  expect(findMax([1.2, 3.5, 2.8])).toBe(3.5);
+});
 
 // Given an array with non-number values
 // When passed to the max function
 // Then it should return the max and ignore non-numeric values
+test("given an array with non-number values, ignores them and returns the max", () => {
+  expect(findMax(['hey', 10, 'hi', 60, 10])).toBe(60);
+});
 
 // Given an array with only non-number values
 // When passed to the max function
 // Then it should return the least surprising value given how it behaves for all other inputs
+test("given an array with only non-number values, returns -Infinity", () => {
+  expect(findMax(['a', 'b', null, undefined])).toBe(-Infinity);
+});

Sprint-1/implement/sum.js

@@ -1,4 +1,9 @@
 function sum(elements) {
+  const numbers = elements.filter((item) => typeof item === "number");
+  if (numbers.length === 0) {
+    return 0;
+  }
+  return numbers.reduce((total, num) => total + num, 0);
 }
 
 module.exports = sum;

Sprint-1/implement/sum.test.js

@@ -13,24 +13,42 @@ const sum = require("./sum.js");
 // Given an empty array
 // When passed to the sum function
 // Then it should return 0
-test.todo("given an empty array, returns 0")
+// test.todo("given an empty array, returns 0")
+test("given an empty array, returns 0", () => {
+  expect(sum([])).toBe(0);
+});
 
 // Given an array with just one number
 // When passed to the sum function
 // Then it should return that number
+test("given an array with one number, returns that number", () => {
+  expect(sum([42])).toBe(42);
+});
 
 // Given an array containing negative numbers
 // When passed to the sum function
 // Then it should still return the correct total sum
+test("given an array with negative numbers, returns the correct total", () => {
+  expect(sum([-5, 10, -3])).toBe(2);
+});
 
 // Given an array with decimal/float numbers
 // When passed to the sum function
 // Then it should return the correct total sum
+test("given an array with decimal numbers, returns the correct total", () => {
+  expect(sum([1.5, 2.5, 3.1])).toBe(7.1);
+});
 
 // Given an array containing non-number values
 // When passed to the sum function
 // Then it should ignore the non-numerical values and return the sum of the numerical elements
+test("given an array with non-number values, ignores them and returns the sum of numbers", () => {
+  expect(sum(["hey", 10, "hi", 60, 10])).toBe(80);
+});
 
 // Given an array with only non-number values
 // When passed to the sum function
 // Then it should return the least surprising value given how it behaves for all other inputs
+test("given an array with only non-number values, returns 0", () => {
+  expect(sum(["a", null, undefined, "b"])).toBe(0);
+});

Sprint-1/refactor/includes.js

@@ -1,8 +1,7 @@
 // Refactor the implementation of includes to use a for...of loop
 
 function includes(list, target) {
-  for (let index = 0; index < list.length; index++) {
-    const element = list[index];
+  for (const element of list) {
     if (element === target) {
       return true;
     }