Skip to content

London | 26-ITP-Sep| Mandip Sanger | Sprint 2 | Coursework - #1469

Open
mandipsanger wants to merge 17 commits into
CodeYourFuture:mainfrom
mandipsanger:coursework-sprint-2
Open

mandipsanger wants to merge 17 commits into
CodeYourFuture:mainfrom
mandipsanger:coursework-sprint-2

Conversation

@mandipsanger

@mandipsanger mandipsanger commented Sep 5, 2026

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1039

Changelist

adding files for sprint 2 coursework

@netlify

netlify Bot commented Sep 5, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 2db087e
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6aac553f20d5910007cca66c
😎 Deploy Preview https://deploy-preview-1469--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

2 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@mandipsanger mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 5, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 5, 2026
@mandipsanger mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 5, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 5, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@mandipsanger mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 5, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 5, 2026
@mandipsanger mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 5, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 5, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 5, 2026
@mandipsanger mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 5, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 5, 2026
@mandipsanger mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 5, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 5, 2026
@mandipsanger mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 5, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 5, 2026
@github-actions

This comment has been minimized.

@mandipsanger mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 7, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 7, 2026
@Liam310 Liam310 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 7, 2026
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Sep 14, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, I have some comments about this one though

Comment thread Sprint-2/1-key-exercises/2-initials.js
Comment thread Sprint-2/3-mandatory-interpret/1-percentage-change.js
Comment thread Sprint-2/3-mandatory-interpret/2-time-format.js
@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Sep 14, 2026
@mandipsanger mandipsanger added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 18, 2026

@abdishakoor-dev abdishakoor-dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a lot of issues to fix before this PR can be closed. I am going to help you out a bit, but you need to pay close attention to the questions and feedback you are getting.

  1. 2-mandatory-errors/0.js has not been started. Put // at the start of lines 1 and 2.

  2. 1-percentage-change.js line 5 is missing a comma. Change replaceAll("," "") to replaceAll(",", "") and the file will run.

  3. 1-percentage-change.js c) asks which lines are reassignments. The answer is lines 4 and 5. What you have under c) now is the answer to b), so move it to b).

  4. 2-time-format.js line 32 says the code works for all values. It does not. It works for non-negative whole numbers, which is what you wrote in your reply on this PR. Put that in the file.

  5. 2-mandatory-errors/1.js. The fix is right, but the section also asks you to explain the error, and you have not done that anywhere yet. Run the original and node prints TypeError: Assignment to constant variable. It happens because age is a const, and a const cannot be given a new value. Write that down, either in the file as a comment or as a reply here. Whichever you prefer.

  6. 2-mandatory-errors/4.js. The renaming is right, but your comments explain how to convert 12 hour time into 24 hour time, which is a different question. The error is SyntaxError: Invalid or unexpected token, because a variable name cannot start with a digit. Explain that instead, again either in the file or as a reply here.

Your explanation in 4-random.js is well done.

Run each file once after you change it. Add the Needs Review label when you have pushed.

@abdishakoor-dev abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants