London | 26-ITP-Sept | Fung Nin Lee | Sprint 2 | JavaScript Fundamentals by leerogerfn · Pull Request #1555 · CodeYourFuture/Module-JavaScript-Fundamentals

leerogerfn · 2026-09-20T22:26:13Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1039

Changelist

I completed all 4 sections of sprint 2 coursework.

netlify · 2026-09-20T22:26:18Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`304a0b2`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6ab13558c9c65f00080f1742
😎 Deploy Preview	https://deploy-preview-1555--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

abdishakoor-dev

You answered every question, and your commits are small and clear. Good work.

Before I can mark this Complete:

Six files stop with an error when you run them. The cause is the same in all six. Your answers are plain text, with no // in front. So node tries to run your answers as code. The files are 1-count.js, 4-random.js, and 0.js, 1.js, 2.js, 3.js in 2-mandatory-errors.
The rule: every line that is not code needs // in front.
After you fix it, run each file with node. There should be no SyntaxError.
In 2-mandatory-errors, the code needs fixing, not only explaining. 1.js, 2.js and 3.js still have the original bug. See my comments.
Some answers in 3-mandatory-interpret need another look: 1-percentage-change.js a), d) and e), and 2-time-format.js f). See my comments.
Please delete the Sprint-2/prep folder. It has your practice files from the prep. They are not part of this task. If you want to keep them, copy them to a folder outside the repo first. Then, in VS Code, right-click the prep folder and choose Delete. Commit and push.
Next time, do not stage practice files. Only commit the files the task asks for.
Most files fail the formatting check. The tool that formats code is called Prettier. It comes with the CYF extension pack from onboarding. If you are not sure you have it, search Extensions in VS Code for CodeYourFuture Extension Pack: https://marketplace.visualstudio.com/items?itemName=CodeYourFuture.cyf-extension-pack
Open each file you changed. Right-click in the editor and choose Format Document. If VS Code asks, pick Prettier. Save, commit and push. To format on every save, follow these steps: https://github.com/CodeYourFuture/Module-JavaScript-Fundamentals/blob/main/practical_guide.md
Do this after step 1. Prettier cannot format a file that has an error.

Add the Needs Review label again when you have pushed.

abdishakoor-dev · 2026-09-21T06:18:18Z

-We don't want the computer to run these 2 lines - how can we solve this problem?
+We don't want the computer to run these 2 lines - how can we solve this problem?
+
+adding // before the lines. 


Your answer is right. Now do it in the file. Put // before lines 1 and 2, and before your answer on line 4. Then node 0.js should print nothing.

That's it. The file runs with no output now.

abdishakoor-dev · 2026-09-21T06:18:18Z

+
+math.floor is round down the number returns to largest integer less than or equal to a given number.
+math.random() could generate the number from 0 to <1 b random.
+maximum refer to 100 and minimum refer to 0.


Your explanation of Math.floor and Math.random() is right. This line says minimum is 0. Check line 1 again.

The question asks what num is. What is the smallest value num can be? And the largest? Run the file several times to check.

Fixed now. Good.

abdishakoor-dev · 2026-09-21T06:18:18Z

+console.log(age)
+
+The error is "Assignment to constant variable." Constant value could not be alternated. 
+if line 3 const changed to let the code could be executed.


Your error message and your reason are right. But line 3 is still const. So the error is still there. Please make the change in the code too.

Fixed. Good.

abdishakoor-dev · 2026-09-21T06:18:18Z

 console.log(`I was born in ${cityOfBirth}`);
 const cityOfBirth = "Bolton";
+
+Initialization should access before the declaration. 


What message does node print for this file? Please write it here.

Then look at the order. Which line runs first, 4 or 5? Fix the code so it prints "I was born in Bolton".

The code works now, good. The error message is still missing. Swap lines 4 and 5 back for a moment. Run the file and copy what node prints to line 7. Then swap them again.

Thanks for adding a message. But it is not from this code. "Cannot find module" means node could not find the file. Look at the path in the message: Sprint-2/2.js.

Please do these steps:

Line 19 is a } with no //. Delete it.

In VS Code, right-click the 2-mandatory-errors folder and choose Open in Integrated Terminal. Run node 2.js.

Copy only the first line of the error to line 8, with // in front. Delete the other error lines.

Put lines 4 and 5 back in the working order. Run the file again. It should print "I was born in Bolton".

That's the right message now, and the file works. Good.

abdishakoor-dev · 2026-09-21T06:18:18Z

 // Consider: Why does it give this error? Is this what I predicted? If not, what's different?
 // Then try updating the expression last4Digits is assigned to, in order to get the correct value
+
+slice is for text or array only. Need to change card number from number to text. Add ''for 4533787178994213. 


Your prediction is right. slice does not work on a number.

Two more steps. Run the file and write down the error node prints. Then fix line 2 so last4Digits gets "4213". The task asks you to change line 2, not the number on line 1.

The fix works, good. The error message is still missing. Remove .toString() for a moment and run the file. Write down the error node prints. Then put .toString() back.

That's the right message. You only need the first line. You can delete the lines below it.

Now add .toString() back on line 2, so the file prints 4213 again.

Fixed. Good.

abdishakoor-dev · 2026-09-21T06:18:18Z

+const twelveHourClockTime = "8:53pm";
+const twentyFourHourClockTime = "20:53";
+
+//integer/number could not start for the initiation.


Your new names work, and the file runs now. Your reason is right too. A name cannot start with a number.

What did node print for the original names? Please add that message here.

Message added. Good.

abdishakoor-dev · 2026-09-21T06:18:18Z

 // Read the code and then answer the questions below

 // a) How many function calls are there in this file? Write down all the lines where a function call is made
+//A: 3


There are more than 3 calls. Number(...) is a call. replaceAll(...) is a call too. How many calls are on line 4? And on line 5?

Closer, but 6 is not right. Write the name of each call, one per line. How many names do you get?

That's right now. Good.

abdishakoor-dev · 2026-09-21T06:18:18Z

+//priceAfterOneYear = Number(priceAfterOneYear.replaceAll(",", ""));

 // d) Identify all the lines that are variable declarations
+//const priceDifference = carPrice - priceAfterOneYear;


Lines 7 and 8 are right. A declaration is any line that creates a variable. let creates a variable too. What do lines 1 and 2 do?

All four now. Good.

abdishakoor-dev · 2026-09-21T06:18:18Z

+//const percentageChange = (priceDifference / carPrice) * 100;

 // e) Describe what the expression Number(carPrice.replaceAll(",","")) is doing - what is the purpose of this expression?
+//A: replacing , with empty string.


That is what replaceAll does. What does Number(...) then do to the result? Why does line 7 need it?

Yes, that is the purpose.

abdishakoor-dev · 2026-09-21T06:18:18Z

+//A: Duration

 // f) Try experimenting with different values of movieLength. Will this code work for all values of movieLength? Explain your answer
+// Yes. Because the variables declaration stated clearly.


Try movieLength as 59, then -60, then 90.5. What does each one print? Would you show a time that way?

Good answer.

… in 2-mandatory-errors. 2-mandatory-errors, original bugs are fixed.

abdishakoor-dev

Nearly all done, and every file now runs without an error. Three small things left:

2-mandatory-errors/2.js line 7: write down the error message node prints.
2-mandatory-errors/3.js line 13: the same. The error message is still missing.
3-mandatory-interpret/1-percentage-change.js line 15: count the calls again.

Add the Needs Review label again when you have pushed.

…centage-changes.js

abdishakoor-dev

Question a) is right now. Two files do not run at the moment:

2-mandatory-errors/2.js: see my comment for the steps.
2-mandatory-errors/3.js line 2: add .toString() back.

Run both files with node before you push. Each should print the right result. Then format both files with Prettier.

Add the Needs Review label again when you have pushed.

abdishakoor-dev

All fixed, and every file runs. Marking this as Complete. Well done.

leerogerfn added 17 commits September 17, 2026 09:34

answered Key exercise question 1 (Count).

d7e51e9

answered Key exercise question 2 (Initials)

045fcb6

answered Key exercise question 3 (paths, dir only)

a0cad5a

modified the answer format on 1-key-exercies 1- count.

5f24463

answered key exercise 4 (random).

444c0fa

answered mandatory error 1.js

88e0415

answered mandatory-errors 2.js

16fdb27

answered mandatory error 3.js

23d0e93

answered 1-key-exercises 3-path

b865cde

answered 2-mandatory-errors 4.js

fbc5f62

answered 2-mandatoy-erros 0.js.

5f5c160

modified the answer of 2-mandatory-error 4.js.

9b9b2fb

answered 3-mandatory-interpret 1-percentage-change.js

ea187a8

answered 3-mandotary 2-time-format.js

f35a334

answered 3-mandatory 3-pounds.js

b06d9e7

answered 4-stretch-explore chrome.md

7344e80

answered 4-stretch-explore 2 object.md

d30d329

leerogerfn added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 20, 2026

abdishakoor-dev reviewed Sep 21, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 21, 2026

leerogerfn added 8 commits September 21, 2026 09:00

deleted folder "prep"

c33ffe5

fixed answers for 1-count.js, 4-random.js, and 0.js, 1.js, 2.js, 3.js…

c914559

… in 2-mandatory-errors. 2-mandatory-errors, original bugs are fixed.

modified answer of 1-key-exercise 4-random.js

55c821c

modfied the spelling of initation of 2-mandatory error 2.js

214738f

modified the answer of 2-mandatory-errors 3.js

3e94e97

modified the answer of 2-mandatory-errors 4.js

a12ff6e

modifed answers of 3-mandatory-interpret 1-percentage-change.js

0071257

modified answers of 3-mandatory-interpret 2-time-format

15661f3

formatted Document for all files.

4ff0efb

leerogerfn added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 21, 2026

abdishakoor-dev reviewed Sep 21, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 21, 2026

leerogerfn added 3 commits September 21, 2026 13:08

updated error message on 2-mandatory-errors 2.js

4786fae

update error message in 2-mandatory-errors 3.js

4edc770

updated the function calls should be 5 in 3-mandatory-interpret 1-per…

6517749

…centage-changes.js

leerogerfn added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 21, 2026

abdishakoor-dev reviewed Sep 21, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 21, 2026

leerogerfn added 3 commits September 21, 2026 14:32

modified the answer of 2-mandatory-errors 2.js

a6fb318

modified answer of 2-mandatory-errors 2.js

54358d2

keep only one error line.

a83fbd0

leerogerfn added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 21, 2026

leerogerfn added 2 commits September 21, 2026 14:40

keep onl y one sentence error message in 2-mandatory-error 3.js

5532a10

keep only 1 line error message on 2-mandatory-errors 3.js

304a0b2

abdishakoor-dev reviewed Sep 21, 2026

View reviewed changes

abdishakoor-dev added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 21, 2026

Uh oh!

Conversation

leerogerfn commented Sep 20, 2026

Learners, PR Template

Task code

Changelist

Uh oh!

netlify Bot commented Sep 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

netlify Bot commented Sep 20, 2026 •

edited

Loading