Skip to content

Cape Town | 26-ITP-Sept | Leigh Ross | Sprint 2 | Complete Sprint 2 Coursework - #1557

Open
leigh-ross wants to merge 26 commits into
CodeYourFuture:mainfrom
leigh-ross:coursework/sprint-2
Open

leigh-ross wants to merge 26 commits into
CodeYourFuture:mainfrom
leigh-ross:coursework/sprint-2

Conversation

@leigh-ross

@leigh-ross leigh-ross commented Sep 21, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1039

Changelist

  • Completed all Sprint 2 questions
  • Fixed broken code
  • Removed prep files from branch

@netlify

netlify Bot commented Sep 21, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit b492e02
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6ab11234ad9db000089b9de6
😎 Deploy Preview https://deploy-preview-1557--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@leigh-ross leigh-ross added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 21, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 21, 2026
@leigh-ross leigh-ross added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 21, 2026
@valentina-starr1

valentina-starr1 commented Sep 21, 2026

Copy link
Copy Markdown

Thanks for working through this. I can see you’ve completed a lot of the exercises and added explanations, which is a good start.

I don’t think this is ready to merge yet though. A few of the submitted solutions are still broken or incomplete, and I’d recommend fixing these before this gets marked complete.

Sprint-2/3-mandatory-interpret/1-percentage-change.js

The replaceAll calls are malformed:
replaceAll("," "") is missing a comma
this causes a syntax error and prevents the program from running
Sprint-2/1-key-exercises/3-paths.js

The directory logic is incorrect:
const dir = filePath.slice(base, -9); doesn’t correctly calculate the directory portion of the path
this should be derived from the file path structure rather than from the filename
Sprint-2/3-mandatory-interpret/2-time-format.js
The value of movieLength was changed from the original example value to 2, which changes the exercise context and output.

This appears to be an accidental change rather than a valid solution to the original task

I’d suggest:

fixing the syntax issues first,
re-running each exercise to confirm the outputs match the task requirements,
and checking that the final files are still aligned with the original instructions rather than leaving placeholder or experimental code in place.

Overall, the work is close, but I’d want these issues resolved before approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants