Glasgow | 26-ITP-May | Christelle Boten | Sprint 2 | Coursework - #1583
Open
Christelle-b wants to merge 10 commits into
Open
Glasgow | 26-ITP-May | Christelle Boten | Sprint 2 | Coursework#1583Christelle-b wants to merge 10 commits into
Christelle-b wants to merge 10 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
5 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
LonMcGregor
reviewed
Aug 1, 2026
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work on most of these, but some still incomplete
| // =============> write your new code here | ||
| function capitalise(str) { | ||
| let strOne = `${str[0].toUpperCase()}${str.slice(1)}`; | ||
| return console.log(strOne); |
There was a problem hiding this comment.
Do we want to print out or return a value here?
| // Finally, correct the code to fix the problem | ||
| // =============> write your new code here | ||
| function convertToPercentage(decimalNumber) { | ||
| const firstDecimal = 0.5; |
There was a problem hiding this comment.
Does this firstDecimal constant do anything in this function?
| } No newline at end of file | ||
| const heightSquare = height * height; | ||
| const newBMI = weight / heightSquare; | ||
| const toOneDecimal = Math.round(newBMI * 10)/10; |
There was a problem hiding this comment.
This isn't wrong, but can you think of a cleaner solution that multiplying then dividing by 10?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
My PR solves all the tasks assigned to sprint 2 of the structure and testing sprint
Questions