London | 26 - ITP-MAY | Ebrahim Moqbel | Sprint 3 | Implement and ewrite tests by Ebrahim-Moqbel · Pull Request #1586 · CodeYourFuture/Module-Structuring-and-Testing-Data

Ebrahim-Moqbel · 2026-07-29T13:24:52Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

completed the implement and rewrite file with fixing a bug

Questions

N/A

…nstead of invalid angle.

…message

Luro91 · 2026-07-30T04:47:51Z

Well done on writing test cases for the border cases.

Luro91 · 2026-07-30T04:49:41Z


 function getCardValue(card) {
  // TODO: Implement this function
+  let rank = card.slice(0,-1);


Why are you using let here?

creating a variable rank and assign the last element which it the face in it.

I also could use const as I won't be updating the variables latter on.

Luro91 · 2026-07-30T04:50:46Z

 function getCardValue(card) {
  // TODO: Implement this function
+  let rank = card.slice(0,-1);
+   let cardFace = card[card.length - 1];


The indendation of this line is not consistent with the rest of the code. How can you ensure to always format your code consistently?

thanks sort it!

Luro91 · 2026-07-30T04:53:19Z

+  if (+rank >= 2 && +rank <= 9) {
+    return +rank;
+  }


What is the purpose of +rank?

converting the string rank to a number.

This happens 3 times. How could you write the code so the conversion is only done once?

Luro91 · 2026-07-30T04:54:08Z

+  if (!["♠", "♥", "♦", "♣"].includes(cardFace)) {
+  }


What does this code do?

In code line number 38 a condition check that the elements k,10,Q,J are in the rank, if so will be returning number 10.
in code line number 41 will be matching the card face if any of the elements are not in CardFace will stop everything and throw an error.

Luro91 · 2026-07-30T04:56:50Z

+test(`Should throw an error when given an invalid card`, () => {
+  expect(() => getCardValue("5X")).toThrow("Invalid card ")}); //invalid suit 
+  expect(() => getCardValue("1♠")).toThrow("Invalid card "); //invalid rank 
+  expect(() => getCardValue("3")).toThrow("Invalid card "); //missing suit 
+})


Vs code shows me an error here. How can you fix it?
Declaration or statement expected.

there was a closing curly bracket and parenthese in line 27.

Luro91 · 2026-07-30T04:57:37Z

+  expect(getCardValue("K♠")).toEqual(10);
+})
 //   Invalid Cards
+test(`Should throw an error when given an invalid card`, () => {


What other invalid cases could you test (which other ranks are invalid and what about a missing rank)

I have added another case in line 27 for testing a missing rank. other invalid cases could be negative ranks.

…ggestions.

Luro91

Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

Reply to their feedback.
- In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
  - You may find the suggestions in this PR Guide useful.
- Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
Replace the "Reviewed" label by a "Needs review" label
- Without this label, the reviewer would not know if your changes is ready to be reviewed.

Luro91 · 2026-08-01T05:27:25Z

+  if (!["♠", "♥", "♦", "♣"].includes(cardFace)) {
+    throw new Error(`Invalid card`);
 }


The indendation of this line is not consistent with the rest of the code. How can you ensure to always format your code consistently? What happens if the condition is false?

Luro91 · 2026-08-01T05:27:56Z

+  if (+rank >= 2 && +rank <= 9) {
+    return +rank;
+  }


This happens 3 times. How could you write the code so the conversion is only done once?

Ebrahim-Moqbel added 8 commits March 6, 2026 16:27

completed the implement exercise

9eed6df

rewrote test with jest

49b88ad

fixed the logic error or the two return value in the finction a

3c92b48

I met the expectation of the error behaviour outcome which is Error i…

bfb2769

…nstead of invalid angle.

Fixed the logic bug( a misplced parenthesis

34ae0f2

I catagrised the error messages and made them consistent

5237b54

matched the Error messages in the test cases with the function error …

e75c8ba

…message

Merge branch 'main' into coursework/sprint-3

12433ce

Ebrahim-Moqbel added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Jul 29, 2026

Luro91 added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jul 30, 2026

Luro91 reviewed Jul 30, 2026

View reviewed changes

fixed some bugs and added some cases answering the reviewer Qs and su…

c9d4307

…ggestions.

Luro91 reviewed Aug 1, 2026

View reviewed changes

added a case for validating the card value in case the rank is invalid.

7ba78d5

Uh oh!

Uh oh!

Conversation

Ebrahim-Moqbel commented Jul 29, 2026

Learners, PR Template

Changelist

Questions

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Luro91 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants