London | 26-ITP-May | Gideon Defar | Sprint 2 | Acoursework/sprint 2` - #1589
Open
gideondefar wants to merge 11 commits into
Open
London | 26-ITP-May | Gideon Defar | Sprint 2 | Acoursework/sprint 2`#1589gideondefar wants to merge 11 commits into
gideondefar wants to merge 11 commits into
Conversation
LonMcGregor
reviewed
Aug 1, 2026
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, just one task to improve a bit more
| // return the BMI of someone based off their weight and height | ||
| } No newline at end of file | ||
| const bmi = weight / (height * height); | ||
| return Math.round(bmi * 10) / 10; |
There was a problem hiding this comment.
This isn't wrong, but can you think of a cleaner solution that multiplying then dividing by 10?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
##Self checklist
##Changelist
Implemented and debugged the Sprint 2 mandatory JavaScript exercises.
The changes include:
Fixed variable declaration and scope errors.
Fixed incorrect function parameters.
Fixed functions that were not returning values correctly.
Fixed the getLastDigit function to use its parameter correctly.
Implemented the BMI calculation.
Implemented UPPER_SNAKE_CASE conversion.
Refactored the pence-to-pounds program.
Completed the formatTimeDisplay function tracing questions.
Tested the programs using Node.js.