London | 26-ITP-May | Gideon Defar | Sprint 3 |Coursework/sprint 3 practice tdd - #1596
Open
gideondefar wants to merge 6 commits into
Open
London | 26-ITP-May | Gideon Defar | Sprint 3 |Coursework/sprint 3 practice tdd#1596gideondefar wants to merge 6 commits into
gideondefar wants to merge 6 commits into
Conversation
LonMcGregor
reviewed
Aug 1, 2026
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, just one of your implementations needs changing
| // When the repeatStr function is called with these inputs, | ||
| // Then it should throw an error, as negative counts are not valid. | ||
|
|
||
| test("should throw an error when count is negative", () => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
##Self checklist
Changelist
Implemented and tested the Sprint 3 TDD exercises using Jest.
The changes include:
Added Jest tests for countChar and implemented the function to count character occurrences.
Added Jest tests for repeatStr, including multiple repetitions, count of 1, count of 0, and negative counts.
Implemented repeatStr without using String.prototype.repeat.
Added Jest tests for getOrdinalNumber, covering different ordinal-number categories and special cases such as 11th, 12th, and 13th.
Implemented the required functions to make the tests pass.
Ran the tests using Jest and verified the expected behaviour.