Fixes minor mistake in calculating whitelisted and blacklisted items to be zipped. - #682
Closed
ItsLJcool wants to merge 4 commits into
Closed
Fixes minor mistake in calculating whitelisted and blacklisted items to be zipped.#682ItsLJcool wants to merge 4 commits into
ItsLJcool wants to merge 4 commits into
Conversation
…ipped It should not add `bannedNames` but allow only `whitelisted` names, even if the item is `whitelisted`, it should ban it from being zipped.
Contributor
Author
|
btw before the pr this made it impossible to choose what files you want to zip lmao You are forced to zip everything |
Contributor
Author
|
Not sure if the new changes work so testing them in a moment |
I made it so <c>whitelist<c> checked <r>every folder<r> instead of the <y>top layer<y> so it would filter out sub-folders when it should only care about <c>whitelist<c> or <l>blacklisting<l> when selecting the first folders. Fixed!
Contributor
Author
|
PR's ready to merge |
Member
|
I'm closing this for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code proves my code makes it work: