Skip to content

[FIX]: RedisRateLimiter 반환 타입 오류 수정 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jm0514 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[FIX]: RedisRateLimiter 반환 타입 오류 수정 #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/main/java/com/example/demo/domain/tweet/service/TweetService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package com.example.demo.domain.tweet.service;

import com.example.demo.domain.follow.FollowRepository;
import com.example.demo.domain.follow.FollowersByUser;
import com.example.demo.domain.timeline.UserTimeline;
import com.example.demo.domain.timeline.UserTimelineRepository;
import com.example.demo.domain.tweet.entity.Tweet;
Expand Down
12 changes: 6 additions & 6 deletions src/main/java/com/example/demo/ratelimiter/aspect/RedisRateLimitAspect.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import com.example.demo.ratelimiter.annotation.RedisRateLimit;
import com.example.demo.ratelimiter.common.RateLimitConfig;
import com.example.demo.ratelimiter.common.RateLimitResult;
import com.example.demo.ratelimiter.common.RateLimiter;
import com.example.demo.ratelimiter.common.RedisRateLimiter;
import jakarta.servlet.http.HttpServletRequest;
import org.aspectj.lang.ProceedingJoinPoint;
import org.aspectj.lang.annotation.Around;
Expand Down Expand Up @@ -45,7 +45,7 @@ public Object around(ProceedingJoinPoint joinPoint, RedisRateLimit redisRateLimi
String key = generateKey(redisRateLimit);

// 해당 Redis 알고리즘의 Rate Limiter 선택
RateLimiter limiter = getRedisRateLimiter(redisRateLimit.algorithm());
RedisRateLimiter limiter = getRedisRateLimiter(redisRateLimit.algorithm());

// 설정에 따른 Rate Limiter 구성
RateLimitResult result;
Expand Down Expand Up @@ -144,12 +144,12 @@ private String getUserId() {
/**
* Redis 알고리즘에 해당하는 Rate Limiter 빈 조회
*/
private RateLimiter getRedisRateLimiter(RedisRateLimit.RedisAlgorithmType algorithm) {
private RedisRateLimiter getRedisRateLimiter(RedisRateLimit.RedisAlgorithmType algorithm) {
try {
return applicationContext.getBean(algorithm.getBeanName(), RateLimiter.class);
return applicationContext.getBean(algorithm.getBeanName(), RedisRateLimiter.class);
} catch (Exception e) {
// 기본값으로 Redis Token Bucket 사용
return applicationContext.getBean("redisTokenBucketLimiter", RateLimiter.class);
return applicationContext.getBean("redisTokenBucketLimiter", RedisRateLimiter.class);
}
}

Expand Down Expand Up @@ -184,7 +184,7 @@ private RateLimitConfig createConfig(RedisRateLimit redisRateLimit) {
* 커스텀 설정으로 Rate Limiter 호출
* 리플렉션을 사용하여 설정을 전달
*/
private RateLimitResult tryAcquireWithConfig(RateLimiter limiter, String key, RateLimitConfig config) {
private RateLimitResult tryAcquireWithConfig(RedisRateLimiter limiter, String key, RateLimitConfig config) {
try {
// tryAcquire(String key, RateLimitConfig config) 메서드가 있는지 확인
Method method = limiter.getClass().getMethod("tryAcquire", String.class, RateLimitConfig.class);
Expand Down