Pin wrangler for telemetry deploys via committed lockfile - #267
Merged
Merged
Conversation
Refs #103 Co-Authored-By: Colonizer <noreply@colonizer.dev>
ParallelEntrepreneur
added a commit
that referenced
this pull request
Sep 23, 2026
Refs #103 Co-Authored-By: Colonizer Settlers <331648616+colonizer-settlers@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why:
Issue #103: the production telemetry worker was deployed by hand with bare
npx wrangler, which resolveswrangler@latestfrom npm at deploy time —the repo's one deploy-time dependency with no pin or hash under the repo's
control. Fixed as suggested in the issue:
services/telemetry/package.json: added exact devDependency"wrangler": "4.135.0"(no caret), sonpx wranglerresolves the pinnedlocal install and dependency audits cover the deploy tool.
services/telemetry/package-lock.json: expanded by npm to lock the fullwrangler tree (this file was already tracked at HEAD by Pin the runtime inputs, attest the release, and audit dependencies in CI #105; this change
only grows it).
services/telemetry/wrangler.tomlheader comment anddocs/telemetry.md"Running the service": deploy commands now usenpx --no-install wrangler, which refuses to fetch from the registry andfails closed if the pinned install is missing; docs note to run
npm cifirst on a fresh checkout so deploys use the committed lockfile.
How verified:
npx --no-install wrangler --versionfromservices/telemetry/→ 4.135.0.npm testinservices/telemetry/: 11 pass, 0 fail.git status --shortshows only the 4 intended files; no stray root-levelfiles or scratch artifacts left behind.
Reviewers / merge notes:
generated
package-lock.json(+1582 lines from wrangler's dependencytree). This exceeds the 400-line soft ceiling, but it is machine-generated
lockfile content that genuinely needs committing for the pin to work; the
hand-written diff is 3 small files. Hand-review only
package.json,wrangler.toml, anddocs/telemetry.md.services/telemetry/package-lock.jsonwas introduced at HEAD bythe Pin the runtime inputs, attest the release, and audit dependencies in CI #105 PR for SBOM coverage; this change builds on it (adds wrangler as
a declared dependency) rather than conflicting with it.
Closes #103
🤖 Generated by Colonizer in a microVM