Skip to content

feat(cw-ibc): clarifying error handling and made asset mapping configurable - #4053

Merged
dzmitry-lahoda merged 1 commit into
mainfrom
dz/314
Aug 11, 2023
Merged

feat(cw-ibc): clarifying error handling and made asset mapping configurable #4053
dzmitry-lahoda merged 1 commit into
mainfrom
dz/314

Conversation

@dzmitry-lahoda

@dzmitry-lahoda dzmitry-lahoda commented Aug 10, 2023

Copy link
Copy Markdown
Contributor

So finally it reaches IBC and sends ICS20, but ICS20 fails on hack from notional around making IBCed pica to be native PICA.

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@dzmitry-lahoda
dzmitry-lahoda changed the base branch from main to dz/313 August 10, 2023 17:37
@github-actions

Copy link
Copy Markdown

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
dzmitry-lahoda 24 8h 22m 23
RustNinja 19 1h 31m 2
blasrodri 16 1h 23m 10
kkast 13 3h 3m 6
mina86 12 1d 37m 79
vmarkushin 2 1h 8m 0
0xBrainjar2 1 3d 17h 35m 6
JafarAz 1 9h 25m 0

@github-actions

Copy link
Copy Markdown
# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4053/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4053/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4053/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4053/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4053/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

@dzmitry-lahoda dzmitry-lahoda changed the title feat(cw-ibc): clarifying error handling and adding asset mapping config feat(cw-ibc): clarifying error handling and made asset mapping configurable Aug 10, 2023
Base automatically changed from dz/313 to main August 10, 2023 21:45
@dzmitry-lahoda
dzmitry-lahoda requested a review from mina86 August 11, 2023 10:08
wtf

logging

need lookup sotrage

query

clippy

forget one config

found missing config

asset config

what next
@dzmitry-lahoda
dzmitry-lahoda marked this pull request as ready for review August 11, 2023 10:53
@dzmitry-lahoda
dzmitry-lahoda added this pull request to the merge queue Aug 11, 2023
Merged via the queue into main with commit 162ca48 Aug 11, 2023
@dzmitry-lahoda
dzmitry-lahoda deleted the dz/314 branch August 11, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants