docs(removal): remove old packages - #4059
Merged
Merged
Conversation
JafarAz
enabled auto-merge
August 11, 2023 18:26
JafarAz
approved these changes
Aug 11, 2023
JafarAz
added this pull request to the merge queue
Aug 11, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 11, 2023
Contributor
|
retry please as per ci issue template |
Contributor
|
ci is distributed system and sometimes need to retry |
Contributor
|
retry pr or ci? I re try failed job twice now |
Contributor
|
@JafarAz would you press Merge When Ready? |
JafarAz
added this pull request to the merge queue
Aug 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@JafarAz
Required for merge:
pr-workflow-check / draft-release-check is ✅ success
Other rules GitHub shows you, or can be read in configuration
Makes review faster:
PR title is my best effort to provide summary of changes and has clear text to be part of release notes
I marked PR by misc label if it should not be in release notes
Linked Zenhub/Github/Slack/etc reference if one exists
I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
Added reviewer into Reviewers
I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
I have proved that PR has no general regressions of relevant features and processes required to release into production
Any dependency updates made, was done according guides from relevant dependency
Clicking all checkboxes
Adding detailed description of changes when it feels appropriate (for example when PR is big)