Skip to content

feat(xcvm): instruction implementation and configuration with osmosis swap - #4083

Merged
dzmitry-lahoda merged 11 commits into
mainfrom
dz/329
Aug 21, 2023
Merged

feat(xcvm): instruction implementation and configuration with osmosis swap#4083
dzmitry-lahoda merged 11 commits into
mainfrom
dz/329

Conversation

@dzmitry-lahoda

@dzmitry-lahoda dzmitry-lahoda commented Aug 17, 2023

Copy link
Copy Markdown
Contributor

So actually implementation of swap instruction with config with mapping for specific exchange of osmosis.

So need to thing about future designs in next iterations. First, is out is always known from pool id, so out is just amount, not coin (but for multi coint it is not the case). Second, if can have twap based slippage as feature like in osmosis, instead of limit. Also if need to bool to suffice like exchange like in XCM. Also if need exchange by delegation (basically Transfer from by delegation or other way to use by delegation).

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists Add XCVM and Osmosis swap contracts to Centauri devnet #3946
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@github-actions

Copy link
Copy Markdown

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
dzmitry-lahoda 29 8h 45m 18
blasrodri 19 2h 33m 6
mina86 17 12h 56m 64
RustNinja 15 1h 17m 2
kkast 11 3h 17m 7
vmarkushin 4 4h 5m 2
JafarAz 3 9h 25m 0
0xBrainjar2 2 3d 17h 35m 6

@github-actions

Copy link
Copy Markdown
# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4083/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4083/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4083/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4083/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4083/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

@dzmitry-lahoda
dzmitry-lahoda marked this pull request as ready for review August 20, 2023 23:59
@dzmitry-lahoda dzmitry-lahoda changed the title feat(xcvm): instruction implementation, confogiration with osmosis swap feat(xcvm): instruction implementation and configuration with osmosis swap Aug 21, 2023
@dzmitry-lahoda
dzmitry-lahoda requested a review from mina86 August 21, 2023 12:57
@dzmitry-lahoda
dzmitry-lahoda requested a review from kkast August 21, 2023 15:03
mina86
mina86 previously approved these changes Aug 21, 2023
Comment thread code/xcvm/cosmwasm/contracts/interpreter/src/contract.rs Outdated
Comment thread code/xcvm/lib/core/src/cosmos.rs
Comment thread code/xcvm/lib/core/src/lib.rs
Comment thread code/Cargo.toml Outdated
Comment thread code/Cargo.toml Outdated
Comment thread code/xcvm/lib/core/src/shared.rs Outdated
Comment thread code/xcvm/cosmwasm/contracts/gateway/src/contract/execute.rs
Comment thread code/xcvm/cosmwasm/contracts/gateway/src/contract/ibc/xcvm.rs
Comment thread flake/release.nix
@dzmitry-lahoda
dzmitry-lahoda added this pull request to the merge queue Aug 21, 2023
@dzmitry-lahoda
dzmitry-lahoda removed this pull request from the merge queue due to a manual request Aug 21, 2023
@dzmitry-lahoda
dzmitry-lahoda added this pull request to the merge queue Aug 21, 2023
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Aug 21, 2023
@dzmitry-lahoda
dzmitry-lahoda merged commit fa2b7b7 into main Aug 21, 2023
@dzmitry-lahoda
dzmitry-lahoda deleted the dz/329 branch August 21, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants