Conversation
Pull reviewers statsStats of the last 30 days for composable:
|
# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4104/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4104/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed # CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4104/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed # run cross chain devnet with Dotsama and Cosmos nodes
nix run "github:ComposableFi/composable/refs/pull/4104/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4104/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh |
|
stale-pr |
dzmitry-lahoda
approved these changes
Aug 31, 2023
dzmitry-lahoda
left a comment
Contributor
There was a problem hiding this comment.
removing code is good, so i think assets must be read from some registry and price feed as technology bith web2 and web3 parts are dead.
lazy-static is often no longer necessary now that OnceCell and OnceLock are a thing. Furthermore, in case of price-feed the lazy initialisation isn’t even necessary: there’s so few entries in mapping that it’s enough to use a static array than build a hash map. Readjust the code to use said static array and remove dependency on lazy-static.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lazy-static is often no longer necessary now that OnceCell and OnceLock
are a thing. Furthermore, in case of price-feed the lazy initialisation
isn’t even necessary: there’s so few entries in mapping that it’s enough
to use a static array than build a hash map.
Readjust the code to use said static array and remove dependency on
lazy-static.
Required for merge:
pr-workflow-check / draft-release-checkis ✅ successMakes review
faster:misclabel if it should not be in release notesReviewers@) or used other form of notification of one person who I think can handle best review of this PR