Skip to content

fix(lsd-relayblock): take relay block number from validation data - #4371

Merged
RustNinja merged 2 commits into
mainfrom
lsd-get-relay-block-number-after-on-finalize
Dec 7, 2023
Merged

fix(lsd-relayblock): take relay block number from validation data#4371
RustNinja merged 2 commits into
mainfrom
lsd-get-relay-block-number-after-on-finalize

Conversation

@RustNinja

Copy link
Copy Markdown
Contributor

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@github-actions

github-actions Bot commented Dec 7, 2023

Copy link
Copy Markdown

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
RustNinja 12 8h 33m 0
dzmitry-lahoda 10 44m 3
kkast 7 1h 29m 1
0xBrainjar2 4 9h 28m 1
blasrodri 2 3d 5m 0
JafarAz 2 6h 22m 0
mina86 1 14h 14m 2
vmarkushin 1 2h 43m 0
rjonczy 1 5d 5h 7m 0

@github-actions

github-actions Bot commented Dec 7, 2023

Copy link
Copy Markdown
# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4371/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4371/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4371/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4371/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4371/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

dzmitry-lahoda
dzmitry-lahoda previously approved these changes Dec 7, 2023
@RustNinja
RustNinja requested a review from blasrodri December 7, 2023 09:51
kkast
kkast previously approved these changes Dec 7, 2023
@RustNinja
RustNinja dismissed stale reviews from kkast and dzmitry-lahoda via 5794d43 December 7, 2023 12:26
@RustNinja
RustNinja merged commit 4ca0559 into main Dec 7, 2023
@RustNinja
RustNinja deleted the lsd-get-relay-block-number-after-on-finalize branch December 7, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants