feat: Add HashedDescription XCM converter and remove TinkernetMultisig configs - #4450
Merged
Conversation
Contributor
|
@arrudagates thank you |
|
stale-pr |
dzmitry-lahoda
requested review from
RustNinja and
kkast
and removed request for
dzmitry-lahoda
February 24, 2024 12:03
RustNinja
reviewed
Feb 27, 2024
|
stale-pr |
|
stale-pr |
Contributor
Author
|
@RustNinja Any blockers on this? |
dzmitry-lahoda
approved these changes
Mar 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the common XCM location converter HashedDescription, which is used across the ecosystem, to Picasso.
Since the current Polkadot SDK version in use does not contain these configs, they are temporarily pulled locally into
parachains/runtime/commonand added to the Picasso runtime from thecommonlocal crate.For reference, chains using HashedDescription include the relay chain and system parachains like the Asset Hub.
Another chain also using HashedDescription but pulling it from a later Polkadot SDK version is Astar
Required for merge:
pr-workflow-check / draft-release-checkis ✅ successMakes review faster:
misclabel if it should not be in release notesReviewers@) or used other form of notification of one person who I think can handle best review of this PR