Add docker port setting for app service#870
Merged
Merged
Conversation
Member
|
This looks great! I'll do a proper code review this week - probably just some syntactic style changes but this looks very good. Thank you very much. |
Contributor
Author
|
Happy to help! Still getting used to F# so there were a few places I wasn't sure about what would be idiomatic, but overall the code base is incredibly well laid out and it was pretty easy to figure out what goes where. I'll definitely be contributing to (and using!) Farmer more in the future. |
github-actions Bot
pushed a commit
that referenced
this pull request
Feb 11, 2022
Add docker port setting for app service 63673cd
Collaborator
|
Thank you, this is released now in 1.6.27. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #869
The changes in this PR are as follows:
I have read the contributing guidelines and have completed the following:
If I haven't completed any of the tasks above, I include the reasons why here:
Below is a minimal example configuration that includes the new features, which can be used to deploy to Azure: