ci(quality): install app deps before enabling app (phpunit job) - #111
Merged
Conversation
The phpunit matrix job ran 'php occ app:enable <app>' inside 'Install Nextcloud'
BEFORE the separate 'Install app dependencies' composer step. Enabling an app
runs its install-scope repair steps, which autowire services with eager
constructors (e.g. OpenRegister's SaveObject does 'new Twig\Environment(...)').
Without vendor/ present that fatals with an uncaught \Error — NC core only
catches \Exception — killing the step ('Class Twig\Extension\AbstractExtension
not found'). The newman/playwright/journeydoc jobs already composer-install
before enabling; this makes the phpunit job consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The phpunit matrix job enabled the app before composer install, so enable-time repair steps autowiring eager constructors (e.g. OpenRegister SaveObject
new Twig\Environment) fatal with an uncaughtErrorwhen vendor is absent (Class Twig\Extension\AbstractExtension not found). Reorder to composer-install-then-enable, matching the newman/playwright/journeydoc jobs. Mirrors Codeberg Conduction/.github#71. Fixes OpenRegister's PHPUnit (NC stable32) CI.