ci(quality): --omit=dev on SBOM npm audit - #112
Merged
Conversation
The SBOM job ran 'npm audit --audit-level=critical' WITHOUT --omit=dev, so it gated on dev-only build-tooling criticals (e.g. tar via node-gyp/cacache) that never ship in the app bundle — it had been red on those regardless. The dedicated 'Security (npm)' job already uses --audit-level=critical --omit=dev; make the SBOM job consistent so both gate only on production-dependency criticals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SBOM job's
npm audit --audit-level=criticalgated on dev-only build-tool criticals (tar via node-gyp/cacache) that never ship. Match theSecurity (npm)job's--omit=devso both gate on production criticals only. Mirrors Codeberg Conduction/.github#72. Fixes OpenRegister's Code Quality SBOM/npm-audit red.