test(feed): name the failure test after the status it actually exercises - #104
Merged
rubenvdlinde merged 1 commit intoAug 12, 2026
Merged
Conversation
FeedRefreshServiceTest::testRefreshFeed500RecordsFailurePreservesItems stubs IResponse::getStatusCode() to 503 and asserts the recorded failure reason starts with "503". The name and the docblock both said 500 — a status nothing in the test produces or checks. The test itself is sound and load-bearing; only the label was wrong. REQ-FRJ-006 is written about per-feed failure tolerance generally and does not single out a status, so 503 is a faithful representative and no coverage changes hands. Renamed, docblock corrected, and the reason for the old label recorded so it is not "fixed" back. Behaviour unchanged; this is a rename plus comments.
rubenvdlinde
requested review from
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
August 12, 2026 07:52
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| composer | ✅ | ✅ 102/102 | |||
| npm | ✅ | ✅ 548/548 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-12 08:11 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
FeedRefreshServiceTest::testRefreshFeed500RecordsFailurePreservesItemsstubsIResponse::getStatusCode()to 503 and asserts the recorded failure reason starts with"503". The name and the docblock both said 500 — a status nothing in the test produces or checks.What changed
testRefreshFeed503RecordsFailurePreservesItems.The test itself is sound and load-bearing; only the label was wrong.
REQ-FRJ-006is written about per-feed failure tolerance generally and does not single out a status, so 503 is a faithful representative and no coverage changes hands.Behaviour is unchanged — this is a rename plus comments. The suite count is unchanged at 1570.
Context
Found while auditing whether this repo's green PHPUnit cells are earned. 159 test names in the suite name an HTTP status; this was the only one whose body never mentions it. Every other status-naming test asserts the matching
Http::STATUS_*constant. That is a good result for the suite, and it is the one exception.