ci: enforce prettier via a format Frontend Check leg - #115
Merged
Conversation
This repo carries `@nextcloud/prettier-config` and a `format` script, but nothing ever ran that script in CI. The shared `quality.yml` has NO prettier job of its own — it mentions prettier ZERO times (eslint 9, stylelint 10) — and `frontend-checks` is the only opt-in that can invoke a repo's own npm scripts. So prettier was active in developers' editors and inert everywhere else: exactly the state the fleet's old `.prettierrc` was deleted for. Appending "format" to the existing `frontend-checks` array adds one `Frontend Check (format)` job. Every pre-existing entry and its order are unchanged. Measured on this tree before enabling, with the same prettier version and the same resolved config CI uses; the per-app scope and result are recorded in the comment above the input. Centralising the config never stopped drift; the gate does.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
August 13, 2026 10:37
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 548/548 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-13 11:11 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Appends
"format"to this repo's existingfrontend-checksarray:Every pre-existing entry and its order are unchanged;
formatis appended last and adds oneFrontend Check (format)job.Why
This repo already carries
@nextcloud/prettier-configand aformat/format:fixscript — but nothing ran that script in CI. The sharedquality.ymlhas no prettier job of its own: it mentions prettier zero times (eslint 9, stylelint 10), andfrontend-checksis the only opt-in that invokes a repo's own npm scripts.So prettier was active in editors and inert in CI — precisely the state the fleet's old
.prettierrcwas deleted for. Formatting would drift straight back between merges. Centralising the config never stopped drift; the gate does.Before this change,
formatwas enforced in 1 of 19 fleet repos (nextcloud-app-template, which is the reference for this input and carries the same rationale).Result on this tree
✅ Clean —
prettier --checkalready passes on this tree, so this PR is the workflow line only.Scope: 237/279 tracked frontend files are in
--check. The remainder is excluded deliberately (generated/vendored/build output) via.prettierignore— plus.gitignore, which prettier 3 reads as an ignore path by default. No.prettierignoreentry needed adding in this repo.How this was measured
Not by eye: with prettier
3.9.6and@nextcloud/prettier-config1.2.0— the same versions this repo'spackage.jsonpins — and the resolved config compared field-by-field against a realnpm ciinstall (identical), on an identical file set. The rig was negative-controlled first: forcing a config change made it flag files, so a green here is a verdict rather than a check that never ran.Expected red that is not from this PR
Hydra GatesandQuality Reportare red on most fleet apps for pre-existing findings. The job to read for this change isFrontend Check (format).