ci(stylelint): cover css/ as well as src/ - #116
Merged
Conversation
The glob was src/**/*.{vue,scss,css}, so css/header-override.css and
css/launchpad.css had never been linted. Both globs (check and fix) widened
together — a stylelint:fix narrower than its check reports done while leaving
violations the check flags, which was a real finding on this app earlier.
Coverage 83 -> 85 files, zero new findings: prettier had already normalised
those stylesheets fleet-wide.
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 548/548 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-14 06:55 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gap
This app's stylelint glob was
src/**/*.{vue,scss,css}— it did not covercss/, sothose stylesheets had never been linted.
@nextcloud/stylelint-config@2.4.0(the version the fleet pins) does shipindentation: 'tab'. The rule was working the whole time; those files were simply nevershown to it. That makes this a coverage gap, not a rule gap — the same family as two
earlier findings in this programme: an unquoted glob the shell expanded, and a
stylelint:fixglob narrower than its ownstylelintcheck.The change
Both globs become
{src,css}/**/*.{vue,scss,css}, quoted so stylelint expands themrather than the shell — unquoted and without
globstar,src/**/matches exactly onedirectory level, which is how 51 files went unlinted on launchpad earlier.
Proof the widened glob actually reaches
css/A glob that silently matches nothing looks exactly like a clean directory, so this was
controlled rather than assumed. On a merged sibling app, planting a space-indented rule
in
css/main.cssproduces:The rule fires. Removed after checking.