fix(security): rate-limit the health probe and public share page - #118
Merged
Conversation
launchpad's last two unthrottled #[PublicPage] endpoints. It now reports ZERO. These were MISSED by the fleet sweep, and the reason is worth recording: an early check reported launchpad as having no git repository, so it was written off as a deployed copy and excluded from every later measurement. It is a normal checkout on development. The app that was already the fleet's BEST at brute-force protection -- PublicShareService is the only service-level IThrottler implementation in the fleet, and the whole sweep copied its shape -- was the one left with unthrottled endpoints. No brute-force counter on either. The share TOKEN is checked by PublicShareController, which already registers failed attempts through PublicShareService; publicShare() is only the shell that hosts it. 120/60 on both, deliberately generous -- a recipient reloading a shared dashboard must not be what trips it. NOT verified locally: launchpad has no vendor/bin/phpunit in this environment, so there is no suite to run. Lint-clean only; CI is the first real run.
rubenvdlinde
requested review from
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
August 14, 2026 15:14
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 536/536 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-14 15:36 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This app's last unthrottled
#[PublicPage]endpoints. It now reports zero.Both of these apps were missed by the original fleet sweep, for opposite reasons worth recording:
development. The app that was already the fleet's best at brute-force protection (PublicShareServiceis the only service-levelIThrottlerimplementation, and this whole sweep copied its shape) was the one left with unthrottled endpoints.No brute-force counters here: nothing takes a guessable credential. The share token is checked by
PublicShareController, which already registers failed attempts; the page is only the shell hosting it.Not verified locally — neither app has
vendor/bin/phpunitin this environment. Lint-clean only; CI is the first real run.Completes the ADR-081/082 sweep (ConductionNL/hydra#554).