ci: rename branch-protection caller job id to branch-protection

[rubenvdlinde]

GitHub names a reusable-workflow status context <caller-job-id> / <called-job-name>.

This repo's caller job id was not branch-protection, so the shared branch-protection
workflow reported under the wrong context name. The org rulesets (Main Branch Protection
id 14128365, Beta Branch Protection id 14128357) require exactly:

branch-protection / check-branch
quality / Quality Report

No name match means the required context never reported at all — not as a failure, as
nothing. The PR sits at BLOCKED forever, and the absence of the check is visually identical to
the check merely not having finished yet. That is the whole defect: a check's absence looks
exactly like its success is still pending.

This renames the caller job id so the context matches. It does not change what is required and
does not touch any ruleset or branch protection — that is a governance decision, not a code
one.

Irony worth recording: this PR itself has to be admin-merged, because the defect it fixes is
precisely what makes the required context unreportable on the current tip.

[github-actions]

Quality Report — ConductionNL/launchpad @ 6dc5108

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	❌
phpmd	❌
psalm	✅
phpstan	✅
phpmetrics	✅
eslint		❌
stylelint		❌
build		✅
composer			✅	✅ 100/100
npm			✅	✅ 416/416
PHPUnit					❌
Newman					⏭️
Playwright					⏭️

---

Quality workflow — 2026-08-04 06:19 UTC

Download the full PDF report from the workflow artifacts.

[rubenvdlinde]

Still needed, still valid — left open deliberately. Verified against the
branch tips rather than by title, since development already carries this fix
and it would be easy to assume main does too:

$ git show origin/development:.github/workflows/branch-protection.yml
  jobs:
    branch-protection:                                     <- already correct
      uses: ConductionNL/.github/.github/workflows/branch-protection.yml@main

$ git show origin/main:.github/workflows/branch-protection.yml
  jobs:
    check:                                                 <- still wrong
      uses: ConductionNL/.github/.github/workflows/branch-protection.yml@main

So main still emits the context check / check-branch while the org ruleset
requires branch-protection / check-branch, and every PR into main sits
permanently pending on a check that will never report. This PR is the fix, and
it is self-demonstrating: on its own head the context resolves and passes —
branch-protection / check-branch SUCCESS.

Blocker: the only thing standing between this and merge is that it targets
main. My remit this session is development, and merging into main is
outside it, so I am not taking that decision on someone else's behalf. It needs
an admin merge by whoever owns the branch-protection workstream.

For the record so nobody re-derives it: the other 8 red jobs here are not
this PR's. They are main's own inherited state — phpcs, phpmd, eslint,
stylelint and all four PHPUnit legs — against a tree that predates a long run
of development work. This PR changes six lines of YAML in one workflow file
and cannot have caused a PHPUnit failure. Do not read them as a regression, and
do not measure them by count against a stale base.

[rubenvdlinde]

Closing: this targeted main directly, which is wrong for app repos — changes must flow development → beta → main. Verified that development already carries the renamed branch-protection caller job id, so this PR is redundant rather than lost.