Added code to find files by searching file content - #148
Closed
WilcoLouwerse wants to merge 1 commit into
Closed
Conversation
Contributor
|
Deze code mag NIET worden gemerged, zie opmerking op -> https://conduction.atlassian.net/browse/REGISTERS-65 |
rubenvdlinde
requested changes
Jan 29, 2025
rubenvdlinde
left a comment
Contributor
There was a problem hiding this comment.
Code niet mergen, in plaats daarvan nexcloud search implementeren -> https://docs.nextcloud.com/server/20/developer_manual/digging_deeper/search.html
rubenvdlinde
added a commit
that referenced
this pull request
Feb 24, 2026
OAS documentation generation was failing with 500 for org-bound registers because RegisterMapper::find() applied multitenancy filtering. Registers with an organisation UUID were inaccessible to users outside that org, including for public API documentation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rubenvdlinde
added a commit
that referenced
this pull request
Feb 24, 2026
The OAS specification endpoint was only returning 1 of 6 schemas because findMultiple() applied multi-tenancy filtering by default. Schemas belonging to organizations other than the current user's were excluded. OAS generation is a system-level operation that needs access to all schemas in a register, regardless of organization ownership. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rubenvdlinde
added a commit
that referenced
this pull request
Mar 1, 2026
Fix OAS path generation to use register/schema slugs with /objects/ prefix instead of slugified titles. Fix MergeHandler getTitle() crash (use getName()), add context cache to prevent N+1 queries, and add set_time_limit(0) for large merge operations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rubenvdlinde
added a commit
that referenced
this pull request
Aug 5, 2026
…failing CI (#2349) v1.0.1 is `f4d9756` (2026-08-03) and predates three gate fixes, so every Hydra Gates run this repo has ever made executed a script in which 16 gates reported PASS when their helper never ran (ConductionNL/.github#147), gate-33 had no axe report to read and never said so (#148), and gates 6 and 7 reported PASS on an empty scope (#149). The tick was identical either way, which is why nothing in this repo's history shows it. That pin is now also RED, and the mechanism is worth writing down. quality.yml is referenced `@main` while this package is PINNED, so the two can desync. #164 flipped `hydra-gates-require-full-coverage` to default true in the shared workflow, and that flag requires a gate to DECLARE itself not-applicable. v1.0.1 contains ZERO `_skip` calls; v1.3.0 has 36. v1.0.1 has no vocabulary to declare, so every absent prerequisite became "DID NOT RUN" and failed the job — for gates the repo has no subject matter for. Measured on this branch, diff-scoped against origin/development exactly as CI scopes it, in a private mount namespace with a private tmpfs (the runner's ~50 /tmp/hydra-gate-*.log paths are shared state and two concurrent runs corrupt each other's counts, .github#158 item 6): v1.0.1 exit 98 FAIL — "GATES THAT DID NOT RUN: 24 33" v1.3.0 exit 0 PASS — those gates named NOT APPLICABLE, with reasons Independently confirmed end-to-end: doriath#160 changed this one line and nothing else, and its Hydra Gates job went failure -> success. v1.3.0 is `f7eaf2a` = .github@main at the time it was cut. Refs ConductionNL/.github#159
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.