Skip to content

ci(quality): restore the missing push trigger — SBOM, Features Extract and the coverage ratchet have not run since March - #432

Merged
rubenvdlinde merged 1 commit into
developmentfrom
fix/restore-push-trigger
Aug 4, 2026
Merged

ci(quality): restore the missing push trigger — SBOM, Features Extract and the coverage ratchet have not run since March#432
rubenvdlinde merged 1 commit into
developmentfrom
fix/restore-push-trigger

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

What

Adds the missing push: trigger to this repo's Code Quality workflow.

The gate that was dark

.github/workflows/code-quality.yml here had only a pull_request: trigger.
It is the only repo in the fleet where that is true — I checked the other 22
callers and every one of them carries the same push: branch list.

Three jobs in the shared quality workflow run only on push:

job its condition
SBOM github.ref must be main / beta / development
Features Extract github.event_name != 'pull_request'
Coverage Baseline Check github.event_name == 'push'

With no push trigger, none of them could ever fire. The last push run on
development is 23289135240, from 2026-03-19
— five months of merges in which
the SBOM was never regenerated, docs/features.json was never checked against
openspec/specs/, and the coverage ratchet never ran.

Why this one was hard to see

Every other dark gate in this sweep was visible in the caller's inputs: an
enable-* sitting at false. This one is not.

  • The inputs all say true.
  • Every PR check is green.
  • The Quality Report on every PR looks complete — because on a pull_request
    those three jobs are correctly skipped, exactly as they are in a healthy repo.

There is no red, no suspicious skip, and no run to inspect. The only way to find
it is to ask "when did a push run last happen here?" — and nothing prompts you
to ask that. It is the fleet's own "a check's absence looks exactly like its
success", one level below the inputs everyone reads.

Sequencing

enable-coverage-guard: true was added here in the previous commit
(#430). Without this trigger its push-side half would have been dead on arrival:
Coverage Baseline Protection would pass on every PR while
Coverage Baseline Check never ran at all.

Expect this first push run to be noisy, and that is the point

Three jobs are about to run for the first time in five months:

Any of those going red is a five-month-old fact becoming visible, not a
regression introduced here.

⚠️ Note on the third one: if it fails it will tell you to fetch the recomputed
value from a coverage-baseline artifact. That artifact does not exist
.coverage-baseline is a dotfile and actions/upload-artifact@v4 skips hidden
files by default. Fixed fleet-wide in ConductionNL/.github#156; until that
merges, read the number from clover.xml in the coverage-report artifact of
the push run on development (not merely the newest artifact — that is how
docudesk and portaliq got wrong values, see ConductionNL/docudesk#379 and
ConductionNL/portaliq#39).

This workflow had only a pull_request trigger - the only caller in the
fleet without a push one. SBOM, Features Extract and Coverage Baseline
Check are push-only jobs, so none of them could ever fire here. The last
push run on development is from 2026-03-19.

Nothing showed this: on a pull_request those three jobs are correctly
skipped, so every PR's Quality Report looked complete. The only way to see
it is to ask when a push run last happened.

enable-coverage-guard was switched on in #430; without this its push-side
half would have been dead on arrival.
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/softwarecatalog @ 6752ac8

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
build
check-manifest
check-vue-demi
test-l10n
composer ✅ 121/121
npm ✅ 849/849
PHPUnit
Newman ⏭️
Playwright

Quality workflow — 2026-08-04 19:45 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde
rubenvdlinde merged commit c984e19 into development Aug 4, 2026
30 checks passed
@rubenvdlinde
rubenvdlinde deleted the fix/restore-push-trigger branch August 4, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant