ci(quality): restore the missing push trigger — SBOM, Features Extract and the coverage ratchet have not run since March - #432
Merged
Conversation
This workflow had only a pull_request trigger - the only caller in the fleet without a push one. SBOM, Features Extract and Coverage Baseline Check are push-only jobs, so none of them could ever fire here. The last push run on development is from 2026-03-19. Nothing showed this: on a pull_request those three jobs are correctly skipped, so every PR's Quality Report looked complete. The only way to see it is to ask when a push run last happened. enable-coverage-guard was switched on in #430; without this its push-side half would have been dead on arrival.
Contributor
Quality Report — ConductionNL/softwarecatalog @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| composer | ✅ | ✅ 121/121 | |||
| npm | ✅ | ✅ 849/849 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ✅ |
Quality workflow — 2026-08-04 19:45 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the missing
push:trigger to this repo's Code Quality workflow.The gate that was dark
.github/workflows/code-quality.ymlhere had only apull_request:trigger.It is the only repo in the fleet where that is true — I checked the other 22
callers and every one of them carries the same
push:branch list.Three jobs in the shared quality workflow run only on
push:SBOMgithub.refmust bemain/beta/developmentFeatures Extractgithub.event_name != 'pull_request'Coverage Baseline Checkgithub.event_name == 'push'With no push trigger, none of them could ever fire. The last push run on
developmentis 23289135240, from 2026-03-19 — five months of merges in whichthe SBOM was never regenerated,
docs/features.jsonwas never checked againstopenspec/specs/, and the coverage ratchet never ran.Why this one was hard to see
Every other dark gate in this sweep was visible in the caller's inputs: an
enable-*sitting atfalse. This one is not.true.pull_requestthose three jobs are correctly skipped, exactly as they are in a healthy repo.
There is no red, no suspicious skip, and no run to inspect. The only way to find
it is to ask "when did a push run last happen here?" — and nothing prompts you
to ask that. It is the fleet's own "a check's absence looks exactly like its
success", one level below the inputs everyone reads.
Sequencing
enable-coverage-guard: truewas added here in the previous commit(#430). Without this trigger its push-side half would have been dead on arrival:
Coverage Baseline Protectionwould pass on every PR whileCoverage Baseline Checknever ran at all.Expect this first push run to be noisy, and that is the point
Three jobs are about to run for the first time in five months:
docs/features.jsonis stale, which afterfive months is likely.
13.01baseline committed in ci(quality): enable the Code Quality gates this repo was silently skipping #430.Any of those going red is a five-month-old fact becoming visible, not a
regression introduced here.
value from a
coverage-baselineartifact. That artifact does not exist —.coverage-baselineis a dotfile andactions/upload-artifact@v4skips hiddenfiles by default. Fixed fleet-wide in ConductionNL/.github#156; until that
merges, read the number from
clover.xmlin thecoverage-reportartifact ofthe push run on
development(not merely the newest artifact — that is howdocudesk and portaliq got wrong values, see ConductionNL/docudesk#379 and
ConductionNL/portaliq#39).