Feature/tracking module - #3
Merged
Merged
Conversation
…r tracking module to match browser-tracking.
…onstructorio-client-javascript into feature/tracking-module
recommendations modules.
Contributor
|
I'd like to pair together on structural changes to increase legibility before merging. It'll probably take a entire pairing session. Things like renaming and shifting files/functions around. |
rubikzube
reviewed
Oct 14, 2019
|
|
||
| #### Send autocomplete search event | ||
| ```javascript | ||
| constructorio.tracker.sendAutocompleteSearch('dogs', { |
Contributor
There was a problem hiding this comment.
We'll need to rename to trackSearchSubmit for consistency with other UI code.
rubikzube
reviewed
Oct 14, 2019
|
|
||
| #### Send autocomplete select event | ||
| ```javascript | ||
| constructorio.tracker.sendAutocompleteSelect('dogs', { |
Contributor
There was a problem hiding this comment.
We'll want to rename all of the sendXxxEvents to trackXxxEvents in the name of consistency with other code.
rubikzube
suggested changes
Oct 14, 2019
|
|
||
| #### Send search results event | ||
| ```javascript | ||
| constructorio.tracker.sendSearchResults('dogs', { |
Contributor
There was a problem hiding this comment.
We'll want to rename sendSearchResults to trackSearchResultsLoaded for consistency with other UI code in iOS/swift/autocomplete
| @@ -1,8 +1,8 @@ | |||
| /* eslint-disable object-curly-newline */ | |||
| /* eslint-disable object-curly-newline, no-underscore-dangle */ | |||
Contributor
There was a problem hiding this comment.
Can we pull changes to autocomplete / search / recommendations into a separate PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5 tracking methods + tests implemented.
Storage library (store2) used for interactions with local and session storage. Tested to verify that no error is thrown in the case of QuotaExceeded error (thanks to overflow add-on).
TODO
FOLLOW-UP
All tests pass (147/147).