Feature/require over import - #4
Merged
Merged
Conversation
rubikzube
reviewed
Oct 3, 2019
| @@ -1,7 +1,7 @@ | |||
| /* eslint-disable import/prefer-default-export, object-curly-newline */ | |||
Contributor
There was a problem hiding this comment.
we can remove the disabling of import/prefer-default-export here
rubikzube
reviewed
Oct 3, 2019
| } | ||
|
|
||
| throw new Error(response.statusText); | ||
| throw response; |
Contributor
There was a problem hiding this comment.
Why are we throwing the entire response here? it's not an error.
Contributor
Author
There was a problem hiding this comment.
it is - if not, response.ok would be true.
rubikzube
reviewed
Oct 3, 2019
| } | ||
|
|
||
| throw new Error(response.statusText); | ||
| throw response; |
Contributor
There was a problem hiding this comment.
Why are we throwing the entire response here?
rubikzube
reviewed
Oct 3, 2019
| } | ||
|
|
||
| throw new Error(response.statusText); | ||
| throw response; |
Contributor
There was a problem hiding this comment.
Why are we throwing the entire response here?
rubikzube
reviewed
Oct 3, 2019
| } | ||
|
|
||
| throw new Error(response.statusText); | ||
| throw response; |
Contributor
There was a problem hiding this comment.
Why are we throwing the entire response here?
This reverts commit a6e847f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
importandexportare only natively supported in Node 12. Revert to usingrequireto increase compatibility with older versions of Node.All tests pass. Code coverage is stable.