Skip to content

refactor: extract shared helper in server actions#311

Merged
pradeeban merged 2 commits into
ControlCore-Project:devfrom
avinxshKD:fix/refactor-server-actions
Feb 19, 2026
Merged

refactor: extract shared helper in server actions#311
pradeeban merged 2 commits into
ControlCore-Project:devfrom
avinxshKD:fix/refactor-server-actions

Conversation

@avinxshKD

@avinxshKD avinxshKD commented Feb 17, 2026

Copy link
Copy Markdown

fixes #310, #313
extracted shared helper for server methods, removed duplicate boilerplate

@avinxshKD

avinxshKD commented Feb 17, 2026

Copy link
Copy Markdown
Author

@pradeeban while refactoring this i noticed the commented-out server sync methods (pushToServer, pullFromServer, etc) taking up arund 70 lines. happy to clean those up if they're not needed for v1,
Also or i should focus more on the main concore repo instead, doing my best as i could let me know if you have a preference

@pradeeban

Copy link
Copy Markdown
Member

@avinxshKD there is a merge conflict. Pls check.
Also, the commented our server sync should be brought back to life. It was a functioning (?) feature sometime back. But was never fully tested to be working. You could check and see if this can be brought back to working. Do not remove the commented out code block.

@avinxshKD

Copy link
Copy Markdown
Author

@pradeeban aye aye captain, I’ll fix the merge conflict and check how we can bring the server sync back to life. Will update once I have something concrete
Btw if there was any specific scenario it was working for earlier, pls let me know, that’ll help while testing.

And I’ll keep the commented code intact :)

@avinxshKD
avinxshKD force-pushed the fix/refactor-server-actions branch from dd8d8cf to 961e20a Compare February 18, 2026 17:18
@pradeeban

Copy link
Copy Markdown
Member

If you go back to https://github.com/NISYSLAB/DHGWorkflow, you may find the code that was working at that moment. Check the history. It was specifically the last three commits, I believe. https://github.com/NISYSLAB/DHGWorkflow/commits/main/

@pradeeban

Copy link
Copy Markdown
Member

While you are on it, pls fix #313 too as it is from the same file and I believe it is just a style issue from your last commit (checked with git blame).

@avinxshKD

Copy link
Copy Markdown
Author

Hey @pradeeban fixed #311 here only, I think keeping it here makes more sense since it's the same file and same root cause.
Though let me know if you'd prefer a separate PR for this, thanks

@avinxshKD

Copy link
Copy Markdown
Author

Also while I was in here I noticed library() still doesn't go through serverAction() , should clean that up too? And redo() in toolbarFunctions.js is missing the null guard that undo() has, looks like it was just missed. Lmk if you want me to pick these up. thanks

@pradeeban

Copy link
Copy Markdown
Member

Ok, go ahead, @avinxshKD. In the meantime, I will merge this one. You can create a new PR for those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants