refactor: extract shared helper in server actions#311
Conversation
|
@pradeeban while refactoring this i noticed the commented-out server sync methods (pushToServer, pullFromServer, etc) taking up arund 70 lines. happy to clean those up if they're not needed for v1, |
|
@avinxshKD there is a merge conflict. Pls check. |
|
@pradeeban aye aye captain, I’ll fix the merge conflict and check how we can bring the server sync back to life. Will update once I have something concrete And I’ll keep the commented code intact :) |
dd8d8cf to
961e20a
Compare
|
If you go back to https://github.com/NISYSLAB/DHGWorkflow, you may find the code that was working at that moment. Check the history. It was specifically the last three commits, I believe. https://github.com/NISYSLAB/DHGWorkflow/commits/main/ |
|
While you are on it, pls fix #313 too as it is from the same file and I believe it is just a style issue from your last commit (checked with git blame). |
|
Hey @pradeeban fixed #311 here only, I think keeping it here makes more sense since it's the same file and same root cause. |
|
Also while I was in here I noticed library() still doesn't go through serverAction() , should clean that up too? And redo() in toolbarFunctions.js is missing the null guard that undo() has, looks like it was just missed. Lmk if you want me to pick these up. thanks |
|
Ok, go ahead, @avinxshKD. In the meantime, I will merge this one. You can create a new PR for those. |
fixes #310, #313
extracted shared helper for server methods, removed duplicate boilerplate