Hand a group reply on after the owner allows it to be shown - #724
Merged
Merged
Conversation
A reply held for private-share permission was written into the transcript and then stopped. The same reply allowed immediately was handed to the Bot it named. Allowing it now relays the same way, including the chain stored on the waiting row.
Bartok9
requested review from
MikeRyanDev,
davidmckayv,
guidovizoso,
mxmzb and
tylerslaton
as code owners
October 2, 2026 23:41
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Fixes #715. A group reply held until its owner allowed it to be shown was written into the transcript and then stopped, so an
@Peerit named was never handed on. Allowing it now calls the samerelaythe immediate path uses, including the chain stored on the waiting row.Where it runs
Boundary and audit
agent.handoff_refused, as the immediate path does.Changelog
CHANGELOG.mdunderUnreleased.Proof
bun test server/tests/group-conversations.integration.test.ts -t "held for the owner's permission"— the new case expects noagent.handoff_offeredwhile the reply is held, then one offer and the peer's reply after the owner allows it.