Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Author
|
Well, an agent straight up did this when I told it I want SMTP plugin, but it is reasonable also hopefully hopefully |
7heMech
marked this pull request as ready for review
September 23, 2026 07:53
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a host-managed SMTP capability for server plugins. Plugins can store mailbox credentials in encrypted secret settings, declare allowed SMTP hosts, and send mail through
api.cms.mail.send. The host enforces the new permission, validates the request, resolves and pins a public address, and requires TLS (465) or STARTTLS (587). The plugin install review displays allowed SMTP hosts.This supports email plugin without a separate webhook relay.
Verification
bun run build— passedbun run lint— passedbun run bootstrap:check— passedbun test— 7,055 passed; three failures: the sandbox RPC target list (fixed after the run and verified in isolation), circular dependency check (15-second test timeout; direct Madge run found no cycles), and an unrelated step-up auth test (5-second timeout, reproduced in isolation)