fix(editor): reuse class usage across unchanged page trees - #583
Draft
marcodantonio-netsons wants to merge 1 commit into
Draft
marcodantonio-netsons wants to merge 1 commit into
marcodantonio-netsons wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading a large site streams collaborative row projections into the editor. Each projection previously rescanned all page and component nodes for canvas CSS and selector badges, even when almost every tree was unchanged. Cache class references by immutable tree identity and keep badge counts stable across edits that do not change class assignments. The publisher retains its uncached collector for mutable construction.
Verified with
bun test(7,056 tests),bun run build,bun run lintandgit diff --check. Regression tests cover changed and unchanged trees, removal/reload, duplicate references, components and script-referenced classes. On a local 1,602-page / 754-component site with 555,054 native nodes, 30 row projections took 1,188 ms for the previous signature scan versus 459 ms for the cached signature plus usage counts. This addresses class scanning; full editor startup performance is still being investigated. No database schema changes.