Mask axel - [merged]

[sfarrens]

In GitLab by @aguinot on Jan 21, 2019, 16:52

Merges mask_Axel -> master

Implementation of Mask module.

[sfarrens]

In GitLab by @sfarrens on Jan 21, 2019, 17:53

This should raise a ValueError instead of an IOError.

[sfarrens]

In GitLab by @sfarrens on Jan 21, 2019, 18:03

Perhaps it would better to use relative paths for example files. e.g. ./example/test_mask/config.mask.

[sfarrens]

In GitLab by @sfarrens on Jan 21, 2019, 18:04

Again, perhaps use relative paths in this example config file, but make sure it works first.

[sfarrens]

In GitLab by @sfarrens on Jan 21, 2019, 18:07

This method would make perfect example for a unit test. Also this method can probably be made static (e.g. using @staticmethod).

[sfarrens]

In GitLab by @aguinot on Jan 21, 2019, 18:49

changed this line in version 2 of the diff

[sfarrens]

In GitLab by @aguinot on Jan 21, 2019, 18:49

changed this line in version 2 of the diff

[sfarrens]

In GitLab by @aguinot on Jan 21, 2019, 18:49

changed this line in version 2 of the diff

[sfarrens]

In GitLab by @aguinot on Jan 21, 2019, 18:49

added 1 commit

• a5a3dd7 - Fix merge review

Compare with previous version

[sfarrens]

In GitLab by @aguinot on Jan 21, 2019, 18:50

It could be nice to discuss that because I'm not really about what to do..

[sfarrens]

In GitLab by @sfarrens on Jan 22, 2019, 10:36

It might be a good idea to break this section into a separate method and use a more descriptive variable than i. Then simply loop over the new method for ['HALO','SPIKE'].