fix: process killing logic - #457
Merged
Merged
Conversation
korivi-CraftOS
added a commit
that referenced
this pull request
Sep 23, 2026
Makes requirements.txt the single source for Python packages; environment.yml keeps only what pip cannot provide (interpreter, tesseract, libcurl, the openssl pin, nodejs) and pulls the rest in with `-r requirements.txt`. Conflict resolution, environment.yml: #457 had just added psutil to the duplicated conda list that this PR removes wholesale. Took this PR's side -- psutil arrives via requirements.txt, where #457 also added it, so nothing is lost. Checked all 49 packages the old conda list carried: every one is either in requirements.txt or deliberately kept as conda-only. None dropped. Note for follow-up, not a defect in this PR: requirements.txt pins nothing (56 packages, zero ==). That predates this change -- the pins removed here lived only in environment.yml's duplicate list, and the default installer path is pip, which has always read the unpinned file. The practical effect is that a fresh install resolves anthropic/openai to majors the code has never been run against (this environment works on anthropic 0.83.0 while the manifest floor says >=0.97.0). Worth a deliberate pinning pass. Suite on the merged result: 1258 passed, 0 failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.