-
-
Notifications
You must be signed in to change notification settings - Fork 44
fix: decode and stop silently truncating inbound integration messages #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4072b4e
fix: decode and stop silently truncating inbound integration messages
ahmad-ajmal 0d19ea0
clean comments
ahmad-ajmal e6d0d7f
clean up comments
ahmad-ajmal dc95e6f
agent recieves truncated information
ahmad-ajmal c553f08
fix incoming message encoding issue
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| """Text shaping for listener message bodies. | ||
|
|
||
| Listeners that cap a body's length (to keep inbound token cost bounded) | ||
| use ``clip`` so every cap cuts the same way and reports that it cut — | ||
| the flag goes to ``PlatformMessage.truncated`` and the host marks the cut. | ||
| """ | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from typing import Tuple | ||
|
|
||
| # How far back from the limit a word boundary may be before we give up | ||
| # and hard-cut (fraction of the limit). | ||
| _BOUNDARY_WINDOW = 0.2 | ||
|
|
||
|
|
||
| def clip(text: str, limit: int) -> Tuple[str, bool]: | ||
| """Cut ``text`` to at most ``limit`` chars, preferring a word boundary. | ||
|
|
||
| Returns ``(clipped, was_clipped)``. No ellipsis is added — the host | ||
| owns presentation of the cut. | ||
| """ | ||
| if len(text) <= limit: | ||
| return text, False | ||
| head = text[:limit] | ||
| cut = max(head.rfind(" "), head.rfind("\n")) | ||
| if cut >= limit * (1 - _BOUNDARY_WINDOW): | ||
| head = head[:cut] | ||
| return head.rstrip(), True |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.