Skip to content

Provide LLM reasoning effort param - #469

Open
zfoong wants to merge 5 commits into
V1.4.4from
llm-reasoning-effort-param
Open

zfoong wants to merge 5 commits into
V1.4.4from
llm-reasoning-effort-param

Conversation

@zfoong

@zfoong zfoong commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

What and why:
Many LLM providers take reasoning effort or thinking budget as params. When none are supplied, the default can be None or medium. This hurts CraftBot's performance, causing suboptimal performance like ending tasks prematurely, ignoring obvious context, and producing bad results and output. This PR supplies the LLM call with these parameters.

However, each provider, and even models within the same provider, can take in different parameters. Therefore, the rules are ALL hard-coded in models/reasoning class. The reason is simple: there is no way to obtain them dynamically.

This can cause a potential issue where any update to the API call will make the list obsolete.

@zfoong
zfoong requested a review from ahmad-ajmal October 1, 2026 02:27
Comment thread agent_core/core/models/reasoning.py
Comment thread agent_core/core/impl/llm/interface.py
Comment thread agent_core/core/impl/llm/interface.py Outdated
Comment thread agent_core/core/models/reasoning.py
Comment thread agent_core/core/models/reasoning.py Outdated
Comment thread agent_core/core/models/reasoning.py
Comment thread agent_core/core/models/reasoning.py
Comment thread agent_core/core/impl/llm/transports/chat_completions.py Outdated
Comment thread agent_core/core/models/reasoning.py
@zfoong

zfoong commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator Author

@ahmad-ajmal Updated! Request review again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants