Conversation
ahmad-ajmal
reviewed
Oct 1, 2026
ahmad-ajmal
reviewed
Oct 1, 2026
Collaborator
Author
|
@ahmad-ajmal Updated! Request review again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why:
Many LLM providers take reasoning effort or thinking budget as params. When none are supplied, the default can be None or medium. This hurts CraftBot's performance, causing suboptimal performance like ending tasks prematurely, ignoring obvious context, and producing bad results and output. This PR supplies the LLM call with these parameters.
However, each provider, and even models within the same provider, can take in different parameters. Therefore, the rules are ALL hard-coded in models/reasoning class. The reason is simple: there is no way to obtain them dynamically.
This can cause a potential issue where any update to the API call will make the list obsolete.