Carry forward 4 unique items from PR #116 (Engine B foundation) - #131
Merged
Conversation
PR #116 was the original Engine B foundation PR. Its bulk was carried in PR #109 via the vendored byte-identical scripts/validate_id_label_correspondence.py (with #109 additionally adding the OK_EXCEPTION mechanism on top). Four items in #116 had NOT yet been carried over: 1. .gitignore — exclude cache/ (the OAK label cache directory created locally during validate runs) 2. scripts/.validate_id_label_correspondence.sha256 — integrity sidecar for the vendored validator; regenerated against the current main copy (which includes #109's OK_EXCEPTION extension) rather than the original PR #116 hash 3. tests/data/optional_binding/omits_bound_optionals.yaml — fixture 4. tests/test_optional_binding_obligation.py — regression test that REQUIRED id↔label bindings on OPTIONAL slots do NOT promote those slots to de-facto required; verified by linkml-term-validator validate-data --labels. Pins the optional-slot contract for shared_environment_term and chebi_term Both new tests pass locally (test_absent_optional_bound_slot_does_not_trip _required_obligation + test_present_wrong_label_is_caught). With this PR landed, PR #116 can be closed as fully superseded. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #116 was the original Engine B foundation PR. Its bulk was carried in PR #109 via the vendored byte-identical `scripts/validate_id_label_correspondence.py` (with #109 additionally adding the OK_EXCEPTION mechanism on top).
This PR carries the 4 remaining items from #116 that #109 didn't include:
With this landed, PR #116 can be closed as fully superseded.
Test plan
🤖 Generated with Claude Code