sd 140 openpost aging filter sort search - #464
Open
sawaneh1 wants to merge 27 commits into
Open
Conversation
…er-lock side effects so it no longer locks/overwrites, allow clearing to blank, and keep other order types' locks intact
|
Warning Review limit reachedNext included review available in 44 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…enpost-aging-filter-sort-search # Conflicts: # api/updateShopCostPrice.php # debitor/rapport.php # importfiler/tekster.csv # includes/reportFunc/showOpenPosts.php # includes/stdFunc/shopApiRequest.php # includes/std_func.php
…enpost-aging-filter-sort-search # Conflicts: # includes/reportFunc/showOpenPosts.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the changes about?
Provide a brief explanation of the changes you have made
Have you checked the following?
https://docs.google.com/document/d/1GOmomtvKf21OV2VWNOIPweDi4gJHpMCK5qXzrPrypUc/edit?usp=sharing
The debtor/creditor open posts report had no way to narrow a long list once on screen: no way to show only accounts owing in ">90", no sort by amount, and changing the account range meant going back to the front page. This adds three things to the report itself, with all state carried in the query string so pagination, the BS toggle, udlign links and accountChart links keep it:
Aging filter — each of the five column headers (>90 … 0-8) is a link; clicking one shows only accounts with an amount in that bucket, with a "Ryd filter" link and a "Filter: …" marker.
Amount sort — ▼/▲ on "I alt" (or on the filtered column) sorts by amount desc/asc.
In-report account search — a field in the header accepting a kontonr, a fra:til range or a firm-name pattern (* wildcard), same rules as the front page. kreditor/rapport.php accepts kontonr for this like debitor/rapport.php.
Implementation: the per-account bucket maths moved unchanged out of the display loop into openpost_account_aging(), and the show-rule into openpost_account_visible(), so filter/sort and the rendered page share one implementation — including the SST-717/SST-730 open-balance rules. When a filter or sort is active, a streaming pre-pass aggregates every matching account (from the same grouped superset the count query uses) and pages the resulting ids; without filter/sort the existing queries run untouched. Request values are whitelisted in openpost_report_state() before reaching SQL/URLs. openpost() no longer overwrites dato/konto with the stored DRV row when the request carries konto_fra/kontonr. Texts 5120–5124 added.
Merged with master twice during review; MB-5, SST-672, SST-717/730 and the async-shell changes are all preserved.