Skip to content

Fix MobilePay silent auth failures, add QR regeneration, persist paym… - #502

Draft
momocoder14 wants to merge 2 commits into
DANOSOFT:masterfrom
momocoder14:fix/mobilepay-auth-and-receipt-id
Draft

Fix MobilePay silent auth failures, add QR regeneration, persist paym…#502
momocoder14 wants to merge 2 commits into
DANOSOFT:masterfrom
momocoder14:fix/mobilepay-auth-and-receipt-id

Conversation

@momocoder14

Copy link
Copy Markdown
Contributor

What are the changes about?

  • Surface Vipps accesstoken/get failures as a clear error instead of hanging on "Afventer QR scan" or continuing with a null token (mobilepay.php, mobilepayListen.php, sys_div_func.php QR setup)
  • Add a "Regenerer QR-kode" button so a stale till QR can be refreshed without manual DB edits (sys_div_func.php + regenerate_mobilepay_qr.php)
  • Persist the Vipps payment reference into pos_betalinger.receipt_id for completed MobilePay payments: pass the reference through the success redirect, rename afslut()'s unused $line parameter to $receipt_id so it actually reaches settlePOS.php, and fix settlePOS.php's (int) cast which zeroed out the varchar column

Have you checked the following?

…ent reference (SST-733)

- Surface Vipps accesstoken/get failures as a clear error instead of
  hanging on "Afventer QR scan" or continuing with a null token
  (mobilepay.php, mobilepayListen.php, sys_div_func.php QR setup)
- Add a "Regenerer QR-kode" button so a stale till QR can be
  refreshed without manual DB edits (sys_div_func.php +
  regenerate_mobilepay_qr.php)
- Persist the Vipps payment reference into pos_betalinger.receipt_id
  for completed MobilePay payments: pass the reference through the
  success redirect, rename afslut()'s unused $line parameter to
  $receipt_id so it actually reaches settlePOS.php, and fix
  settlePOS.php's (int) cast which zeroed out the varchar column

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7552b89b-fdb2-4f32-8238-79a25aecd60f


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@momocoder14
momocoder14 marked this pull request as ready for review August 24, 2026 01:54
@momocoder14
momocoder14 requested a review from a team August 24, 2026 01:54
@momocoder14
momocoder14 marked this pull request as draft August 24, 2026 02:32
@momocoder14
momocoder14 marked this pull request as ready for review August 24, 2026 09:53
@momocoder14
momocoder14 marked this pull request as draft August 24, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant