Skip to content

Allow pre-releases and fix error message in DIRAC version check#771

Merged
aldbr merged 2 commits into
DIRACGrid:integrationfrom
maxnoe:fix_version_check
Feb 17, 2026
Merged

Allow pre-releases and fix error message in DIRAC version check#771
aldbr merged 2 commits into
DIRACGrid:integrationfrom
maxnoe:fix_version_check

Conversation

@maxnoe

@maxnoe maxnoe commented Jan 15, 2025

Copy link
Copy Markdown
Contributor

BEGINRELEASENOTES
FIX: Allow pre-releases in the DIRAC version check when starting the WebAPP and allow pre-releases for development
ENDRELEASENOTES

@maxnoe maxnoe force-pushed the fix_version_check branch from 7fb289a to 272955a Compare January 26, 2026 15:02
@maxnoe maxnoe changed the base branch from rel-v5r0 to integration January 26, 2026 15:02
@maxnoe maxnoe marked this pull request as ready for review January 26, 2026 16:23
@aldbr

aldbr commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

In the next few days, I will try to run the branch in certification, if it does not break, then I will merge it, thanks!

@fstagni

fstagni commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

Given that we will not have anymore pre-releases (ever!), I do not think this is needed. Re-open if you think I am wrong.

@fstagni fstagni closed this Feb 10, 2026
@maxnoe

maxnoe commented Feb 10, 2026

Copy link
Copy Markdown
Contributor Author

Given that we will not have anymore pre-releases (ever!), I do not think this is needed. Re-open if you think I am wrong.

The motivation for this change was local development! Where the version is based on the last tag plus some .devXXX git information, aka a pre-release.

It also fixes a genuine bug in the error message.

@maxnoe

maxnoe commented Feb 10, 2026

Copy link
Copy Markdown
Contributor Author

At least the fix for the error message should be taken. I can split if you want, but I think this should go in

@aldbr aldbr reopened this Feb 10, 2026
@fstagni

fstagni commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

Given that we will not have anymore pre-releases (ever!), I do not think this is needed. Re-open if you think I am wrong.

The motivation for this change was local development! Where the version is based on the last tag plus some .devXXX git information, aka a pre-release.

It also fixes a genuine bug in the error message.

Ah, sorry about that. Re-opened then.

@aldbr aldbr merged commit 6dd232f into DIRACGrid:integration Feb 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants