Skip to content

feat:Exposing more props to renderPane for EditorTab(invalid) - #757

Closed
Zaoei wants to merge 2 commits into
DTStack:mainfrom
Zaoei:feat/extension_parameters
Closed

feat:Exposing more props to renderPane for EditorTab(invalid)#757
Zaoei wants to merge 2 commits into
DTStack:mainfrom
Zaoei:feat/extension_parameters

Conversation

@Zaoei

@Zaoei Zaoei commented Jun 1, 2022

Copy link
Copy Markdown
Collaborator

Description

exposing more props to renderPane for EditorTab

Fixes #649

Changes

  • tab.renderPane method arguments add tab and group
  • add renderPane example

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@Zaoei
Zaoei requested review from mortalYoung, mumiao and wewoor June 1, 2022 14:15
@Zaoei Zaoei self-assigned this Jun 1, 2022
@Zaoei Zaoei added this to the 0.9.0-beta.5 milestone Jun 1, 2022
@Zaoei
Zaoei force-pushed the feat/extension_parameters branch from 1943679 to 57d56c7 Compare June 1, 2022 14:21
@mortalYoung

Copy link
Copy Markdown
Collaborator

为啥没有跑 codecov 呢 0.0

@mumiao mumiao added the feature label Jun 2, 2022
@mumiao

mumiao commented Jun 2, 2022

Copy link
Copy Markdown
Collaborator

#757

@wewoor wewoor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mumiao

mumiao commented Jun 2, 2022

Copy link
Copy Markdown
Collaborator

+1

@Zaoei

Zaoei commented Jun 2, 2022

Copy link
Copy Markdown
Collaborator Author

@mortalYoung 我解决了冲突之后提交,就没有走 codecov。要不关闭这个 pr,我重新提一个?

@Zaoei

Zaoei commented Jun 2, 2022

Copy link
Copy Markdown
Collaborator Author

@mortalYoung @mumiao @wewoor
由于没有走 codecov,关闭这个 PR。
改用 #759

@Zaoei Zaoei changed the title feat:Exposing more props to renderPane for EditorTab feat:Exposing more props to renderPane for EditorTab(invalid) Jun 2, 2022
@wewoor wewoor closed this Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat:Exposing more props to renderPane for EditorTab

4 participants