Fix FastSourceLineResolver link errors on MinGW - #25
Merged
Conversation
module_factory.h unnecessarily depended on BasicSourceLineResolver and
FastSourceLineResolver. Fix this by moving the derived factory classes
to {basic,fast}_source_line_resolver.cc. The MinGW linker is more picky
and complains about the unmet dependency of an unused class.
This also reverts commit d54e2fd
which was a previous fix for one of the instances of the problem.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a redo of #23. It turns out various unit test binaries suffer from the same linking issue so I fixed the code this time instead of spamming the spurious dependency everywhere.
module_factory.h unnecessarily depended on BasicSourceLineResolver and FastSourceLineResolver. Fix this by moving the derived factory classes to {basic,fast}_source_line_resolver.cc. The MinGW linker is more picky and complains about the unmet dependency of an unused class.
Reverts commit d54e2fd which was a previous fix for one of the instances of the problem.