Disable parts of tests that fail on MinGW - #28
Merged
Conversation
illwieckz
reviewed
Jul 27, 2026
|
|
||
| namespace { | ||
|
|
||
| // It seems a few bells and whistles aren't availble with MinGW. |
Member
|
I rebased this over my That's a progress anyway! |
Member
|
Just for knowledge, here is the status on Wine, but that may be Wine limitations (we may send them the test so they can use it to track down differences with Windows): This is also a progress since it went from 17 failed tests to 15 (I'm aware that lest test are running 🫣️). |
illwieckz
approved these changes
Jul 27, 2026
illwieckz
left a comment
Member
There was a problem hiding this comment.
LGTM if:
- the comment typo is fixed
- the remaining fails aren't regressions introduced by this
Member
|
Hmm, I just noticed that I just tested a non-static build of |
Member
|
I wouldn't exclude the remaining fails may be related to the MinGW version I'm using (13.2.0). |
Member
|
I did more runs, here with a more recent MinGW (14.2.0 from Debian Trixie) and some more recent Wine, dynamic link: Wine 10.0: Wine 11.13: Windows 11: So a newer MinGW helped on Wine, but not on Windows (at least up to MinGW 14.2.0). |
Member
Author
|
I developed this against #24 excluding the |
Member
Nice! So it's basically a matter of MinGW updates to get everything passing on Windows! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that all tests pass.