Skip to content

Guard aura countdown handling for missing cooldown data #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanderBot merged 2 commits into from
Dec 1, 2025
Merged

Guard aura countdown handling for missing cooldown data #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1208432
Fix countdown formatting guards
DanderBot Dec 1, 2025
3a22855
Merge branch 'main' into codex/add-countdown-formatting-options-for-b…
DanderBot Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 45 additions & 42 deletions DandersFrames_Auras.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,53 +140,56 @@ function DF:ApplyAuraLayout(frame)
local cd = self.cooldown
local text = self:GetParent().dfCountdownText

-- Use our stored values instead of API calls
if cd and cd:IsShown() then
-- Capture any cooldown values we might have missed before the SetCooldown hook ran
if (not cd.dfStart or not cd.dfDuration) and cd.GetCooldownTimes then
local start, duration = cd:GetCooldownTimes()
if start and duration then
-- GetCooldownTimes returns milliseconds
start = start / 1000
duration = duration / 1000

if duration > 0 then
cd.dfStart = start
cd.dfDuration = duration
end
end
end
if not (cd and cd:IsShown() and text) then
if text then text:Hide() end
return
end

-- Capture any cooldown values we might have missed before the SetCooldown hook ran
if (not cd.dfStart or not cd.dfDuration) and cd.GetCooldownTimes then
local start, duration = cd:GetCooldownTimes()
if start and duration then
-- GetCooldownTimes returns milliseconds
start = start / 1000
duration = duration / 1000

if cd.dfStart and cd.dfDuration and cd.dfDuration > 0 then
local remaining = (cd.dfStart + cd.dfDuration) - GetTime()

if remaining > 0.5 then
if remaining >= 3600 then
text:SetText(math.floor(remaining / 3600) .. "h")
elseif remaining >= 60 then
text:SetText(math.floor(remaining / 60) .. "m")
elseif remaining >= 10 then
text:SetText(math.floor(remaining))
elseif remaining >= 3 then
text:SetFormattedText("%.0f", remaining)
else
if countdownDecimalMode == "WHOLE" then
text:SetFormattedText("%.0f", remaining)
else
text:SetFormattedText("%.1f", remaining)
end
end

text:Show()
else
text:Hide()
if duration > 0 then
cd.dfStart = start
cd.dfDuration = duration
end
else
text:Hide()
end
else
end

local hasStart = type(cd.dfStart) == "number"
local hasDuration = type(cd.dfDuration) == "number"

if not (hasStart and hasDuration and cd.dfDuration > 0) then
text:Hide()
return
end

local remaining = (cd.dfStart + cd.dfDuration) - GetTime()

if remaining <= 0.5 then
text:Hide()
return
end

if remaining >= 3600 then
text:SetText(math.floor(remaining / 3600) .. "h")
elseif remaining >= 60 then
text:SetText(math.floor(remaining / 60) .. "m")
elseif remaining >= 10 then
text:SetText(math.floor(remaining))
elseif countdownDecimalMode == "WHOLE" then
text:SetText(math.ceil(remaining))
elseif remaining >= 3 then
text:SetFormattedText("%.0f", remaining)
else
text:SetFormattedText("%.1f", remaining)
end

text:Show()
end)
aura.dfCountdownOverlay.hasOnUpdate = true
end
Expand Down