Skip to content

Safely handle secret values in aura countdown updates #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanderBot merged 2 commits into from
Dec 1, 2025
Merged

Safely handle secret values in aura countdown updates #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1aa163c
Handle secret cooldown values in aura countdown
DanderBot Dec 1, 2025
343dd84
Merge branch 'main' into codex/add-countdown-formatting-options-for-b…
DanderBot Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions DandersFrames_Auras.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,22 @@ function DF:ApplyAuraLayout(frame)
return
end

local function safeNumber(value)
if type(value) ~= "number" then
return nil
end

local ok, coerced = pcall(function()
return value + 0
end)

if ok then
return coerced
end

return nil
end

-- Capture any cooldown values we might have missed before the SetCooldown hook ran
if (not cd.dfStart or not cd.dfDuration) and cd.GetCooldownTimes then
local start, duration = cd:GetCooldownTimes()
Expand All @@ -160,17 +176,19 @@ function DF:ApplyAuraLayout(frame)
end
end

local hasStart = type(cd.dfStart) == "number"
local hasDuration = type(cd.dfDuration) == "number"
local start = safeNumber(cd.dfStart)
local duration = safeNumber(cd.dfDuration)

if not (hasStart and hasDuration and cd.dfDuration > 0) then
if not (start and duration and duration > 0) then
text:Hide()
return
end

local remaining = (cd.dfStart + cd.dfDuration) - GetTime()
local ok, remaining = pcall(function()
return (start + duration) - GetTime()
end)

if remaining <= 0.5 then
if not ok or remaining <= 0.5 then
text:Hide()
return
end
Expand Down