Merge bitcoin/bitcoin#27499: net processing, refactor: Decouple PeerManager from gArgs

[DashCoreAutoGuix]

Backports bitcoin#27499

Original commit: c97270d

Backported from Bitcoin Core v0.26

[coderabbitai]

Warning

Rate limit exceeded

@DashCoreAutoGuix has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 24 minutes and 16 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 9f3e4fa and 5f2bc33.

📒 Files selected for processing (9)

• src/Makefile.am (2 hunks)
• src/init.cpp (2 hunks)
• src/net_processing.cpp (14 hunks)
• src/net_processing.h (2 hunks)
• src/node/peerman_args.cpp (1 hunks)
• src/node/peerman_args.h (1 hunks)
• src/node/txreconciliation.h (0 hunks)
• src/test/denialofservice_tests.cpp (4 hunks)
• src/test/util/setup_common.cpp (2 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch backport-0.26-batch-441-pr-27499

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[DashCoreAutoGuix]

❌ Backport Verification - CATASTROPHIC FAILURE

Original Bitcoin commit: c97270d722
Reviewed commit hash: 5f2bc33c17-verify-1753645184

Critical violations detected:

• File Operation Mismatch: Bitcoin commit modifies existing file src/node/peerman_args.cpp, but Dash PR creates it as a new file
• This indicates importing entire Bitcoin infrastructure rather than adapting existing Dash code
• Bitcoin intent: Modify existing argument handling
• Dash result: Import entire new argument handling infrastructure

Auto-rejection reasoning:
This type of file operation mismatch signals dependency explosion - bringing in entire Bitcoin components instead of making targeted changes to existing Dash code. This violates the faithful backporting principle of minimal adaptations.

Recommended action:
Close this PR and create a new backport that either:

1. Skips this commit if the functionality isn't needed in Dash
2. Adapts the changes to work with Dash's existing argument handling patterns
3. Ensures file operations match (modify existing files, don't create new infrastructure)

This PR has been automatically closed due to critical validation failures.

[DashCoreAutoGuix]

Automatically closed due to catastrophic validation failures. Please see the detailed analysis above and create a new PR with a proper backport implementation.