[TON-707] Attach rendered instrumentation IAM policies#338
Open
fanny-jiang wants to merge 4 commits into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Please remember to review the contribution guidelines
if you have not yet done so.
What does this PR do?
policy_documentsusing the target AWS account and partitiondatadog_integration_permissions.yamlMotivation
Move IAM statement rendering and chunking into instrumenter-config, which owns the permission definitions, and keep the CloudFormation Lambda focused on attaching the resulting documents. The quota preflight prevents cleanup when the final document count cannot fit on the role.
Testing Guidelines
python3 -B -S -m unittest discover -p "*_test.py"fromaws_quickstart(56 tests)attach_integration_permissions.pyAdditional Notes
permissions; missingpolicy_documentsis treated as an instrumentation failurev4.16.0and the policy attachment schema version to2